Bug 63210 - Tighten type usage in the Shadow tree code
Summary: Tighten type usage in the Shadow tree code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-22 18:06 PDT by Julien Chaffraix
Modified: 2011-06-22 19:26 PDT (History)
2 users (show)

See Also:

Attachments
Proposed change: tighten the types, rename one variable, make a method public as it should. (7.13 KB, patch)
2011-06-22 18:12 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2011-06-22 18:06:17 PDT 
While looking at the code, I found out that the type of shadowRoot() was not strictly enforced. The API should make it obvious what is expected as an argument.

Patch forthcoming.
Comment 1 Julien Chaffraix 2011-06-22 18:12:52 PDT 
Created attachment 98281 [details]
Proposed change: tighten the types, rename one variable, make a method public as it should.
Comment 2 WebKit Review Bot 2011-06-22 19:26:39 PDT 
Comment on attachment 98281 [details]
Proposed change: tighten the types, rename one variable, make a method public as it should.

Clearing flags on attachment: 98281

Committed r89521: <http://trac.webkit.org/changeset/89521>
Comment 3 WebKit Review Bot 2011-06-22 19:26:43 PDT 
All reviewed patches have been landed.  Closing bug.