WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
63210
Tighten type usage in the Shadow tree code
https://bugs.webkit.org/show_bug.cgi?id=63210
Summary
Tighten type usage in the Shadow tree code
Julien Chaffraix
Reported
2011-06-22 18:06:17 PDT
While looking at the code, I found out that the type of shadowRoot() was not strictly enforced. The API should make it obvious what is expected as an argument. Patch forthcoming.
Attachments
Proposed change: tighten the types, rename one variable, make a method public as it should.
(7.13 KB, patch)
2011-06-22 18:12 PDT
,
Julien Chaffraix
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Julien Chaffraix
Comment 1
2011-06-22 18:12:52 PDT
Created
attachment 98281
[details]
Proposed change: tighten the types, rename one variable, make a method public as it should.
WebKit Review Bot
Comment 2
2011-06-22 19:26:39 PDT
Comment on
attachment 98281
[details]
Proposed change: tighten the types, rename one variable, make a method public as it should. Clearing flags on attachment: 98281 Committed
r89521
: <
http://trac.webkit.org/changeset/89521
>
WebKit Review Bot
Comment 3
2011-06-22 19:26:43 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug