Bug 63198 - Use create() method for AsyncAudioDecoder::DecodingTask
Summary: Use create() method for AsyncAudioDecoder::DecodingTask
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-22 16:06 PDT by Chris Rogers
Modified: 2011-06-22 17:02 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.12 KB, patch)
2011-06-22 16:10 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (3.03 KB, patch)
2011-06-22 16:41 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (3.53 KB, patch)
2011-06-22 16:52 PDT, Chris Rogers
levin: review+
levin: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2011-06-22 16:06:51 PDT
Use create() method for AsyncAudioDecoder
Comment 1 Chris Rogers 2011-06-22 16:10:37 PDT
Created attachment 98259 [details]
Patch
Comment 2 Chris Rogers 2011-06-22 16:11:34 PDT
This addresses a missed review comment by David Levin.
Comment 3 David Levin 2011-06-22 16:26:30 PDT
Comment on attachment 98259 [details]
Patch

Miscommunication.
Comment 4 Chris Rogers 2011-06-22 16:41:54 PDT
Created attachment 98264 [details]
Patch
Comment 5 Chris Rogers 2011-06-22 16:44:01 PDT
sorry David, uploading one more patch with the create method implementation in the .cpp file
Comment 6 WebKit Review Bot 2011-06-22 16:46:09 PDT
Comment on attachment 98264 [details]
Patch

Attachment 98264 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8926722
Comment 7 David Levin 2011-06-22 16:47:15 PDT
Comment on attachment 98264 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98264&action=review

Feel free to do your move to the cpp file on checkin (and the chromium build fix).

> Source/WebCore/webaudio/AsyncAudioDecoder.h:56
> +        static OwnPtr<DecodingTask> create(ArrayBuffer* audioData, double sampleRate, PassRefPtr<AudioBufferCallback> successCallback, PassRefPtr<AudioBufferCallback> errorCallback)

Return type should be PassOwnPtr. (I thought we checked this, but if not, I'll add a style check quickly.)
Comment 8 Chris Rogers 2011-06-22 16:52:01 PDT
Created attachment 98265 [details]
Patch
Comment 9 David Levin 2011-06-22 16:53:33 PDT
Comment on attachment 98265 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98265&action=review

> Source/WebCore/webaudio/AsyncAudioDecoder.h:56
> +        static OwnPtr<DecodingTask> create(ArrayBuffer* audioData, double sampleRate, PassRefPtr<AudioBufferCallback> successCallback, PassRefPtr<AudioBufferCallback> errorCallback);

PassOwnPtr :)

Filed bug https://bugs.webkit.org/show_bug.cgi?id=63204 (I'll have a patch up soon.)
Comment 10 Chris Rogers 2011-06-22 17:02:09 PDT
Committed r89499: <http://trac.webkit.org/changeset/89499>