Use create() method for AsyncAudioDecoder
Created attachment 98259 [details] Patch
This addresses a missed review comment by David Levin.
Comment on attachment 98259 [details] Patch Miscommunication.
Created attachment 98264 [details] Patch
sorry David, uploading one more patch with the create method implementation in the .cpp file
Comment on attachment 98264 [details] Patch Attachment 98264 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8926722
Comment on attachment 98264 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98264&action=review Feel free to do your move to the cpp file on checkin (and the chromium build fix). > Source/WebCore/webaudio/AsyncAudioDecoder.h:56 > + static OwnPtr<DecodingTask> create(ArrayBuffer* audioData, double sampleRate, PassRefPtr<AudioBufferCallback> successCallback, PassRefPtr<AudioBufferCallback> errorCallback) Return type should be PassOwnPtr. (I thought we checked this, but if not, I'll add a style check quickly.)
Created attachment 98265 [details] Patch
Comment on attachment 98265 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98265&action=review > Source/WebCore/webaudio/AsyncAudioDecoder.h:56 > + static OwnPtr<DecodingTask> create(ArrayBuffer* audioData, double sampleRate, PassRefPtr<AudioBufferCallback> successCallback, PassRefPtr<AudioBufferCallback> errorCallback); PassOwnPtr :) Filed bug https://bugs.webkit.org/show_bug.cgi?id=63204 (I'll have a patch up soon.)
Committed r89499: <http://trac.webkit.org/changeset/89499>