WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
63196
Make Chromium Mac and Linux tests bot core builders
https://bugs.webkit.org/show_bug.cgi?id=63196
Summary
Make Chromium Mac and Linux tests bot core builders
Ryosuke Niwa
Reported
2011-06-22 15:45:38 PDT
Chromium Mac and Linux Tests bots have been stable for the last couple of weeks. We should make them core builders.
Attachments
Patch
(7.89 KB, patch)
2011-06-22 15:53 PDT
,
Ryosuke Niwa
abarth
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2011-06-22 15:48:30 PDT
Sounds great!
Adam Barth
Comment 2
2011-06-22 15:50:16 PDT
http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Tests%29?numbuilds=200
says that Make Chromium Mac and Linux tests bot core builders has been red about 40% of the time in the last 200 runs.
http://build.webkit.org/builders/Chromium%20Linux%20Release%20%28Tests%29?numbuilds=200
says that Chromium Linux has been green less than 50% of the last 200 runs.
Ryosuke Niwa
Comment 3
2011-06-22 15:53:50 PDT
Created
attachment 98255
[details]
Patch
Ryosuke Niwa
Comment 4
2011-06-22 16:00:36 PDT
(In reply to
comment #2
)
>
http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Tests%29?numbuilds=200
> > says that Make Chromium Mac and Linux tests bot core builders has been red about 40% of the time in the last 200 runs.
which might be better than Snow Leopard:
http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20(Tests)?numbuilds=200
Ryosuke Niwa
Comment 5
2011-06-22 16:03:42 PDT
Also comparable to Qt Release:
http://build.webkit.org/builders/Qt%20Linux%20Release?numbuilds=200
Adam Barth
Comment 6
2011-06-22 16:09:50 PDT
Yes. We should remove those from the list of core builders, IMHO. The core page is too red now to be useful.
Ryosuke Niwa
Comment 7
2011-06-22 16:27:42 PDT
(In reply to
comment #6
)
> Yes. We should remove those from the list of core builders, IMHO. The core page is too red now to be useful.
The rest of core builders are worse. Windows and GTK are almost always red. We'll have no tests core builders. The problem is that people are landing patches that make the tree red, not that people aren't taking care of bots.
Ryosuke Niwa
Comment 8
2011-07-11 11:39:00 PDT
http://build.webkit.org/builders/Chromium%20Linux%20Release%20%28Tests%29?numbuilds=200
http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Tests%29?numbuilds=200
Looking at the last 200 revisions, these bots are at least as green as any other test bots if not greener:
http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29?numbuilds=200
http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Debug?numbuilds=200
http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug?numbuilds=200
http://build.webkit.org/builders/Qt%20Linux%20Release?numbuilds=200
Adam Barth
Comment 9
2011-07-11 11:50:20 PDT
Ok. Your persistence is commendable.
Ryosuke Niwa
Comment 10
2011-07-11 13:18:10 PDT
(In reply to
comment #9
)
> Ok. Your persistence is commendable.
Thanks for r+. I'll land it later when the tree is less busy.
Ryosuke Niwa
Comment 11
2011-07-11 19:17:39 PDT
Committed
r90804
: <
http://trac.webkit.org/changeset/90804
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug