Bug 63194 – TestFailures page should show closed bugs, too

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Roben (:aroben)]

The TestFailures page shows bugs related to the failing tests. But it only shows open bugs. It would be useful to show closed bugs, too. This would be particularly useful in cases where a bug has just been fixed but the bots haven't caught up yet. We'd probably want to indicate in the UI whether a particular bug was open or closed.

[Adam Roben (:aroben)]

Created attachment 98353 [details]
Show closed bugs on the TestFailures page in addition to open ones

[David Kilzer (:ddkilzer)]

Comment on attachment 98353 [details]
Show closed bugs on the TestFailures page in addition to open ones

View in context: https://bugs.webkit.org/attachment.cgi?id=98353&action=review

r=me

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:238
> +            list.appendChildren(openBugs.map(bugToListItem));

What if all the bugs found are closed?  Shouldn't you check if openBugs.length here, or is that checked above?

    if (openBugs.length)
        list.appendChildren(openBugs.map(bugToListItem));

[Adam Roben (:aroben)]

Comment on attachment 98353 [details]
Show closed bugs on the TestFailures page in addition to open ones

View in context: https://bugs.webkit.org/attachment.cgi?id=98353&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:238
>> +            list.appendChildren(openBugs.map(bugToListItem));
> 
> What if all the bugs found are closed?  Shouldn't you check if openBugs.length here, or is that checked above?
> 
>     if (openBugs.length)
>         list.appendChildren(openBugs.map(bugToListItem));

If openBugs is an empty array, then the appendChildren call will do nothing, which is what we want. (The only reason we check closedBugs.length below is to avoid adding the "Closed bugs:" list item if there are no closed bugs.)

[Adam Roben (:aroben)]

Committed r89571: <http://trac.webkit.org/changeset/89571>