Bug 63193 – convert editing/deleting/delete-select-all-00* to dumpAsText

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Wyatt Carss]

convert editing/deleting/delete-select-all-00* to dumpAsText

[Wyatt Carss]

Created attachment 98252 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 98252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98252&action=review

> LayoutTests/editing/deleting/delete-select-all-002-expected.txt:1
> +

We should have editing delegates.

> LayoutTests/editing/deleting/delete-select-all-002.html:45
> -runEditingTest();
> +runDumpAsTextEditingTest();

You can do that by passing "true" to runDumpAsTextEditingTest.

[Wyatt Carss]

Created attachment 98316 [details]
Patch

[Wyatt Carss]

Adding delegates makes life awful with git, because it raises the number of lines in common between the new baselines and the old ones, which causes git (with its wacky renaming philosophy) to think I've renamed files instead of deleting some and adding some others. Also, shouldn't delete-select-all-001 show delegates too?

[Ryosuke Niwa]

Note that you can add cq? when you uploaded your patch.  Then reviewer will r+ and cq+ simultaneously.

[WebKit Review Bot]

The commit-queue encountered the following flaky tests while processing attachment 98316 [details]:

http/tests/local/fileapi/file-last-modified.html bug 63294 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Review Bot]

Comment on attachment 98316 [details]
Patch

Clearing flags on attachment: 98316

Committed r89623: <http://trac.webkit.org/changeset/89623>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.