Bug 63193 - convert editing/deleting/delete-select-all-00* to dumpAsText
Summary: convert editing/deleting/delete-select-all-00* to dumpAsText
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-22 15:31 PDT by Wyatt Carss
Modified: 2011-06-23 15:12 PDT (History)
5 users (show)

See Also:

Attachments
Patch (45.66 KB, patch)
2011-06-22 15:34 PDT, Wyatt Carss 		no flags Details | Formatted Diff | Diff
Patch (23.77 KB, patch)
2011-06-22 23:02 PDT, Wyatt Carss 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wyatt Carss 2011-06-22 15:31:47 PDT 
convert editing/deleting/delete-select-all-00* to dumpAsText
Comment 1 Wyatt Carss 2011-06-22 15:34:46 PDT 
Created attachment 98252 [details]
Patch
Comment 2 Ryosuke Niwa 2011-06-22 19:22:03 PDT 
Comment on attachment 98252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98252&action=review

> LayoutTests/editing/deleting/delete-select-all-002-expected.txt:1
> +

We should have editing delegates.

> LayoutTests/editing/deleting/delete-select-all-002.html:45
> -runEditingTest();
> +runDumpAsTextEditingTest();

You can do that by passing "true" to runDumpAsTextEditingTest.
Comment 3 Wyatt Carss 2011-06-22 23:02:53 PDT 
Created attachment 98316 [details]
Patch
Comment 4 Wyatt Carss 2011-06-22 23:11:58 PDT 
Adding delegates makes life awful with git, because it raises the number of lines in common between the new baselines and the old ones, which causes git (with its wacky renaming philosophy) to think I've renamed files instead of deleting some and adding some others. Also, shouldn't delete-select-all-001 show delegates too?
Comment 5 Ryosuke Niwa 2011-06-23 14:52:07 PDT 
Note that you can add cq? when you uploaded your patch.  Then reviewer will r+ and cq+ simultaneously.
Comment 6 WebKit Review Bot 2011-06-23 15:09:57 PDT 
The commit-queue encountered the following flaky tests while processing attachment 98316 [details]:

http/tests/local/fileapi/file-last-modified.html bug 63294 (author: jianli@chromium.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Review Bot 2011-06-23 15:12:03 PDT 
Comment on attachment 98316 [details]
Patch

Clearing flags on attachment: 98316

Committed r89623: <http://trac.webkit.org/changeset/89623>
Comment 8 WebKit Review Bot 2011-06-23 15:12:08 PDT 
All reviewed patches have been landed.  Closing bug.