Bug 63191 - accessibility/aria-labelledby-overrides-aria-label.html failing on Windows since it was added
Summary: accessibility/aria-labelledby-overrides-aria-label.html failing on Windows si...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Alice Boxhall
URL: http://build.webkit.org/results/Windo...
Keywords: LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2011-06-22 15:17 PDT by Adam Roben (:aroben)
Modified: 2011-07-01 07:18 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.91 KB, patch)
2011-06-24 20:56 PDT, Alice Boxhall
no flags Details | Formatted Diff | Diff
Patch (16.16 KB, patch)
2011-06-27 18:33 PDT, Alice Boxhall
no flags Details | Formatted Diff | Diff
Patch (7.57 KB, patch)
2011-06-28 21:45 PDT, Alice Boxhall
no flags Details | Formatted Diff | Diff
Patch (2.33 KB, patch)
2011-06-29 18:33 PDT, Alice Boxhall
no flags Details | Formatted Diff | Diff
Patch (1.48 KB, patch)
2011-06-29 18:49 PDT, Alice Boxhall
no flags Details | Formatted Diff | Diff
Patch (7.88 KB, patch)
2011-06-29 19:04 PDT, Alice Boxhall
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-06-22 15:17:14 PDT
accessibility/aria-labelledby-overrides-aria-label.html failing on Windows since it was added in r89204.

http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r89261%20(13941)/results.html
Comment 1 chris fleizach 2011-06-22 15:28:22 PDT
Test needs to be updated likely
Comment 2 Adam Roben (:aroben) 2011-06-23 06:52:35 PDT
Landed expected failure results

Committed r89565: <http://trac.webkit.org/changeset/89565>
Comment 3 chris fleizach 2011-06-24 15:14:39 PDT
Alice, do you have an update on this
Comment 4 Alice Boxhall 2011-06-24 20:56:07 PDT
Created attachment 98573 [details]
Patch
Comment 5 Alice Boxhall 2011-06-24 20:58:22 PDT
Comment on attachment 98573 [details]
Patch

Hm, that didn't work as I had hoped. I have moved the test in to platform/win and platform/mac, but I still need to run it on Windows to generate the appropriate expectations. I will take another look on Monday Sydney time and hopefully successfully upload the patch then.
Comment 6 Alice Boxhall 2011-06-27 18:33:15 PDT
Created attachment 98839 [details]
Patch
Comment 7 Alice Boxhall 2011-06-27 18:34:44 PDT
Comment on attachment 98573 [details]
Patch

Interim patch; will update Windows test and expectations from Windows machine.
Comment 8 Adam Roben (:aroben) 2011-06-28 08:23:51 PDT
Comment on attachment 98839 [details]
Patch

Seems like the Windows results need to be updated, not just deleted. Maybe that's what you meant by "interim"? If so, you probably shouldn't have marked the patch r?.

It's really unfortunate that we have to duplicate the test for the two platforms. Maybe we should just dump the attributes instead of using shouldBe? Then each platform could have its own expected results using the same test and you wouldn't have any FAIL text.
Comment 9 Alice Boxhall 2011-06-28 16:43:44 PDT
(In reply to comment #8)
> (From update of attachment 98839 [details])
> Seems like the Windows results need to be updated, not just deleted. Maybe that's what you meant by "interim"? If so, you probably shouldn't have marked the patch r?.

Yes; sorry, I should have passed --no-review and forgot. But yes, that is what I meant by "interim" (and I did add that I intended to update the test and expectations from my Windows machine).

> It's really unfortunate that we have to duplicate the test for the two platforms. Maybe we should just dump the attributes instead of using shouldBe? Then each platform could have its own expected results using the same test and you wouldn't have any FAIL text.

Ah, that would be a better solution, indeed. I will do so and update the patch.
Comment 10 Alice Boxhall 2011-06-28 21:45:54 PDT
Created attachment 99033 [details]
Patch
Comment 11 Alice Boxhall 2011-06-29 18:33:54 PDT
Created attachment 99201 [details]
Patch
Comment 12 Alice Boxhall 2011-06-29 18:49:10 PDT
Created attachment 99205 [details]
Patch
Comment 13 Alice Boxhall 2011-06-29 19:04:12 PDT
Created attachment 99209 [details]
Patch
Comment 14 WebKit Review Bot 2011-07-01 07:18:53 PDT
Comment on attachment 99209 [details]
Patch

Clearing flags on attachment: 99209

Committed r90226: <http://trac.webkit.org/changeset/90226>
Comment 15 WebKit Review Bot 2011-07-01 07:18:58 PDT
All reviewed patches have been landed.  Closing bug.