Bug 63174 - Don't draw border as one path unless there really are 4 borders
Summary: Don't draw border as one path unless there really are 4 borders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-06-22 13:05 PDT by Beth Dakin
Modified: 2011-06-22 13:45 PDT (History)
2 users (show)

See Also:

Attachments
Patch (25.62 KB, patch)
2011-06-22 13:23 PDT, Beth Dakin 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2011-06-22 13:05:17 PDT 
Title says it all. If we DO draw the border as one path when there aren't really 4 borders, the accelerated drawing codepath can mis-render.

Patch coming soon!

<rdar://problem/9457997>
Comment 1 Beth Dakin 2011-06-22 13:23:16 PDT 
Created attachment 98228 [details]
Patch
Comment 2 Simon Fraser (smfr) 2011-06-22 13:27:12 PDT 
Comment on attachment 98228 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98228&action=review

> LayoutTests/fast/borders/only-one-border-with-width.html:13
> +      border-right: 1px solid rgba(0, 0, 0, 0.15);

Can you make it thicker so it's more obvious in the testcase?

May also want to consider moving the text into an HTML comment to avoid spurious text diffs between platforms.
Comment 3 Beth Dakin 2011-06-22 13:29:35 PDT 
(In reply to comment #2)
> 
> Can you make it thicker so it's more obvious in the testcase?
> 

Yes! Good call.

> May also want to consider moving the text into an HTML comment to avoid spurious text diffs between platforms.

Will do.
Comment 4 Beth Dakin 2011-06-22 13:45:20 PDT 
Committed change with revision 89475.