Bug 63163 - Add preference for setting the html parser depth limit
Summary: Add preference for setting the html parser depth limit
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-22 11:51 PDT by Sam Weinig
Modified: 2011-06-23 07:10 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.02 KB, patch)
2011-06-22 11:52 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-06-22 11:51:51 PDT 
Add preference for setting the html parser depth limit
Comment 1 Sam Weinig 2011-06-22 11:52:40 PDT 
Created attachment 98210 [details]
Patch
Comment 2 Sam Weinig 2011-06-22 13:13:59 PDT 
Committed r89469: <http://trac.webkit.org/changeset/89469>
Comment 3 mitz 2011-06-22 13:51:06 PDT 
Comment on attachment 98210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98210&action=review

> Source/WebKit/mac/WebView/WebPreferencesPrivate.h:242
> +- (void)setMaximumHTMLParserDOMTreeDepth:(unsigned)depth;
> +- (unsigned)maximumHTMLParserDOMTreeDepth;

Should use NSUInteger instead of unsigned here.
Comment 4 Sam Weinig 2011-06-22 15:03:47 PDT 
(In reply to comment #3)
> (From update of attachment 98210 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98210&action=review
> 
> > Source/WebKit/mac/WebView/WebPreferencesPrivate.h:242
> > +- (void)setMaximumHTMLParserDOMTreeDepth:(unsigned)depth;
> > +- (unsigned)maximumHTMLParserDOMTreeDepth;
> 
> Should use NSUInteger instead of unsigned here.

Ok, I actually think I want to back this out.  There isn't a super compelling reason for it as it turns out.
Comment 5 Sam Weinig 2011-06-22 17:17:39 PDT 
Rolled out the patch in 89501.
Comment 6 Alexey Proskuryakov 2011-06-23 01:01:40 PDT 
So, changing resolution to WONTFIX.

I can't see how the preference could be a good idea - either the depth limit doesn't affect real life Web sites, or the limit should be the same across all WebKit ports for compatibility.
Comment 7 Sam Weinig 2011-06-23 07:10:20 PDT 
(In reply to comment #6)
> So, changing resolution to WONTFIX.
> 
> I can't see how the preference could be a good idea - either the depth limit doesn't affect real life Web sites, or the limit should be the same across all WebKit ports for compatibility.

The initial intent of the preference was for applications that don't care as much about about web compatibilty (such as mail client).