Bug 63163 – Add preference for setting the html parser depth limit

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[Sam Weinig]

Add preference for setting the html parser depth limit

[Sam Weinig]

Created attachment 98210 [details]
Patch

[Sam Weinig]

Committed r89469: <http://trac.webkit.org/changeset/89469>

Comment on attachment 98210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98210&action=review

> Source/WebKit/mac/WebView/WebPreferencesPrivate.h:242
> +- (void)setMaximumHTMLParserDOMTreeDepth:(unsigned)depth;
> +- (unsigned)maximumHTMLParserDOMTreeDepth;

Should use NSUInteger instead of unsigned here.

[Sam Weinig]

(In reply to comment #3)
> (From update of attachment 98210 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98210&action=review
> 
> > Source/WebKit/mac/WebView/WebPreferencesPrivate.h:242
> > +- (void)setMaximumHTMLParserDOMTreeDepth:(unsigned)depth;
> > +- (unsigned)maximumHTMLParserDOMTreeDepth;
> 
> Should use NSUInteger instead of unsigned here.

Ok, I actually think I want to back this out.  There isn't a super compelling reason for it as it turns out.

[Sam Weinig]

Rolled out the patch in 89501.

[Alexey Proskuryakov]

So, changing resolution to WONTFIX.

I can't see how the preference could be a good idea - either the depth limit doesn't affect real life Web sites, or the limit should be the same across all WebKit ports for compatibility.

[Sam Weinig]

(In reply to comment #6)
> So, changing resolution to WONTFIX.
> 
> I can't see how the preference could be a good idea - either the depth limit doesn't affect real life Web sites, or the limit should be the same across all WebKit ports for compatibility.

The initial intent of the preference was for applications that don't care as much about about web compatibilty (such as mail client).