Bug 63161 – Canvas in layer obscures overlapping span

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Matthew Delaney]

I'm attaching a patch with accompanying testcase that should show the span atop the canvas. Without the patch, if the canvas is in its own compositing layer then it will be incorrectly rendered atop the span.

[Matthew Delaney]

Created attachment 98208 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 98208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98208&action=review

> LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html:34
> +    html, body {
> +    	width: 480px;
> +    	height: 640px;
> +    }
> +    body {
> +    	margin :0px;
> +    	padding: 0px;
> +    }
> +    #headerbar {
> +    	width: 200px;
> +    	height: 40px;
> +    	background-color: #333333;
> +    	position: absolute;
> +    }
> +    #testaction {
> +    	color: #FFFFFF;
> +    }

This CSS is weirdly indented.

> LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html:38
> +	<div id="headerbar"><span id='testlabel'></span><span id='testaction'>This text should be visible.</a></div>

Please avoid text in the pixel output.

Also, avoid scrollbars in the pixel output.

I also think this could use layerTreeAsText(). However, you'll have to deal with different platforms having different results.

[Matthew Delaney]

Created attachment 98214 [details]
Patch

[Matthew Delaney]

Uggh, CSS is still junky indented. Fixing again now.

[Matthew Delaney]

Created attachment 98218 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 98218 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98218&action=review

> LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html:25
> +            background-color: #FF0000;

Please use green, not red (and use names, not hex values for common colors).

[Matthew Delaney]

Created attachment 98229 [details]
Patch

[Matthew Delaney]

Read that comment on color values backwards - definitely need more sleep...New patch it a second.

[Matthew Delaney]

Created attachment 98232 [details]
Patch

[Matthew Delaney]

Committed r89474: <http://trac.webkit.org/changeset/89474>