RESOLVED FIXED 63160
Web Inspector: [refacotring] extensions test: replace dispatchOnFrontend with a more generic evaluateOnFrontend() 
https://bugs.webkit.org/show_bug.cgi?id=63160
Summary Web Inspector: [refacotring] extensions test: replace dispatchOnFrontend with...
Andrey Kosyakov
Reported 2011-06-22 11:21:20 PDT
We used to have somewhat defective mechanism for the tests running in the extension context to invoke some selected methods on the front-end. Over the time the need evolved for a more generic mechanism similar to the way it's done from the tested page. This switches all methods that used to rely on dispatchOnFrontend() to evaluateOnFrontend(), also moves some of the less-used methods from extensions-test.js to particular test files that need them.
Attachments
patch (12.48 KB, patch)
2011-06-22 11:24 PDT, Andrey Kosyakov 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2011-06-22 11:24:50 PDT
Created attachment 98205 [details] patch
Yury Semikhatsky
Comment 2 2011-06-23 04:51:04 PDT
Comment on attachment 98205 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=98205&action=review > LayoutTests/http/tests/inspector/extensions-test.js:25 > + var reply = InspectorTest._replyToExtension.bind(null, event.ports[0]); Please add a comment that this variable may be used by the eval'ed code.
Andrey Kosyakov
Comment 3 2011-06-24 01:04:02 PDT
Manually committed r89656: http://trac.webkit.org/changeset/89656
Note You need to log in before you can comment on or make changes to this bug.