Bug 63160 - Web Inspector: [refacotring] extensions test: replace dispatchOnFrontend with a more generic evaluateOnFrontend()
Summary: Web Inspector: [refacotring] extensions test: replace dispatchOnFrontend with...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
Depends on:
Reported: 2011-06-22 11:21 PDT by Andrey Kosyakov
Modified: 2011-06-24 01:04 PDT (History)
10 users (show)

See Also:

patch (12.48 KB, patch)
2011-06-22 11:24 PDT, Andrey Kosyakov
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2011-06-22 11:21:20 PDT
We used to have somewhat defective mechanism for the tests running in the extension context to invoke some selected methods on the front-end. Over the time the need evolved for a more generic mechanism similar to the way it's done from the tested page.
This switches all methods that used to rely on dispatchOnFrontend() to evaluateOnFrontend(), also moves some of the less-used methods from extensions-test.js to particular test files that need them.
Comment 1 Andrey Kosyakov 2011-06-22 11:24:50 PDT
Created attachment 98205 [details]
Comment 2 Yury Semikhatsky 2011-06-23 04:51:04 PDT
Comment on attachment 98205 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=98205&action=review

> LayoutTests/http/tests/inspector/extensions-test.js:25
> +        var reply = InspectorTest._replyToExtension.bind(null, event.ports[0]);

Please add a comment that this variable may be used by the eval'ed code.
Comment 3 Andrey Kosyakov 2011-06-24 01:04:02 PDT
Manually committed r89656: http://trac.webkit.org/changeset/89656