Bug 63158 - nrwt: don't look for http lock when running the test port
Summary: nrwt: don't look for http lock when running the test port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-22 11:04 PDT by Dirk Pranke
Modified: 2011-06-22 14:52 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.35 KB, patch)
2011-06-22 11:05 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-06-22 11:04:45 PDT
nrwt: don't look for http lock when running the test port
Comment 1 Dirk Pranke 2011-06-22 11:05:28 PDT
Created attachment 98201 [details]
Patch
Comment 2 Dirk Pranke 2011-06-22 11:06:44 PDT
minor fix to make the unit tests stop trying to take out a real file lock when they shouldn't be. Also changed the mock_drt code so that the methods show up in the same order.
Comment 3 WebKit Review Bot 2011-06-22 14:51:22 PDT
The commit-queue encountered the following flaky tests while processing attachment 98201 [details]:

http/tests/media/pdf-served-as-pdf.html bug 63187 (authors: annacc@chromium.org, jamesr@chromium.org, jer.noble@apple.com, and vrk@chromium.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Review Bot 2011-06-22 14:52:42 PDT
Comment on attachment 98201 [details]
Patch

Clearing flags on attachment: 98201

Committed r89483: <http://trac.webkit.org/changeset/89483>
Comment 5 WebKit Review Bot 2011-06-22 14:52:46 PDT
All reviewed patches have been landed.  Closing bug.