Bug 63157 – REGRESSION (r89407): Text in search field in Safari's find banner is too low on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Adam Roben (:aroben)]

Created attachment 98200 [details]
screenshot

To reproduce:

1. Go to any page
2. Press Ctrl-F to show the find banner
3. Type some text in the find banner's search field

The text is too low. See screenshot.

[Adam Roben (:aroben)]

Looks like this started happening in r89407: http://trac.webkit.org/changeset/89407

Note that the search field contains a WebView with an <input> element.

[Adam Roben (:aroben)]

<rdar://problem/9656624>

[Adam Roben (:aroben)]

r89407 was rolled out in r89460.

[Kent Tamura]

(In reply to comment #0)
> Created an attachment (id=98200) [details]
> screenshot

What OS version are you using?
I couldn't reproduce this issue with Safari 5.0.4 + WebKit with r89407 on Snow Leopard. The search field appearance in the screenshot looks different.

[Kent Tamura]

Ah, it's on Windows.  I see.

[Kent Tamura]

Does it have any additional CSS properties?

[Adam Roben (:aroben)]

Created attachment 98372 [details]
testcase

Here's a testcase. In r89407, you can see that the baseline of the text in the search field is below the border, while in ToT it is above the border.

[Kent Tamura]

(In reply to comment #7)
> Created an attachment (id=98372) [details]
> testcase
> 
> Here's a testcase. In r89407, you can see that the baseline of the text in the search field is below the border, while in ToT it is above the border.

Thank you!  It's very helpful.

[Kent Tamura]

The purpose of r89407 is to use the standard CSS rendering as possible, and I wanted to make RenderTextControlSingleLine honored paddings. However the testcase expects it ignores paddings.
So, I decided to introduce a special handling for type=search so that only type=search ignores paddings if the content box of <input> is smaller than the text height.