Bug 63157 - REGRESSION (r89407): Text in search field in Safari's find banner is too low on Windows
Summary: REGRESSION (r89407): Text in search field in Safari's find banner is too low ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, PlatformOnly, Regression
Depends on:
Blocks: 61415
  Show dependency treegraph
 
Reported: 2011-06-22 11:03 PDT by Adam Roben (:aroben)
Modified: 2011-06-29 06:37 PDT (History)
5 users (show)

See Also:


Attachments
screenshot (1.58 KB, image/png)
2011-06-22 11:03 PDT, Adam Roben (:aroben)
no flags Details
testcase (289 bytes, text/html)
2011-06-23 10:55 PDT, Adam Roben (:aroben)
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-06-22 11:03:03 PDT
Created attachment 98200 [details]
screenshot

To reproduce:

1. Go to any page
2. Press Ctrl-F to show the find banner
3. Type some text in the find banner's search field

The text is too low. See screenshot.
Comment 1 Adam Roben (:aroben) 2011-06-22 11:03:27 PDT
Looks like this started happening in r89407: http://trac.webkit.org/changeset/89407

Note that the search field contains a WebView with an <input> element.
Comment 2 Adam Roben (:aroben) 2011-06-22 11:04:09 PDT
<rdar://problem/9656624>
Comment 3 Adam Roben (:aroben) 2011-06-22 12:59:15 PDT
r89407 was rolled out in r89460.
Comment 4 Kent Tamura 2011-06-22 18:49:50 PDT
(In reply to comment #0)
> Created an attachment (id=98200) [details]
> screenshot

What OS version are you using?
I couldn't reproduce this issue with Safari 5.0.4 + WebKit with r89407 on Snow Leopard. The search field appearance in the screenshot looks different.
Comment 5 Kent Tamura 2011-06-22 18:53:28 PDT
Ah, it's on Windows.  I see.
Comment 6 Kent Tamura 2011-06-22 23:48:32 PDT
Does it have any additional CSS properties?
Comment 7 Adam Roben (:aroben) 2011-06-23 10:55:57 PDT
Created attachment 98372 [details]
testcase

Here's a testcase. In r89407, you can see that the baseline of the text in the search field is below the border, while in ToT it is above the border.
Comment 8 Kent Tamura 2011-06-24 05:22:39 PDT
(In reply to comment #7)
> Created an attachment (id=98372) [details]
> testcase
> 
> Here's a testcase. In r89407, you can see that the baseline of the text in the search field is below the border, while in ToT it is above the border.

Thank you!  It's very helpful.
Comment 9 Kent Tamura 2011-06-28 22:37:19 PDT
The purpose of r89407 is to use the standard CSS rendering as possible, and I wanted to make RenderTextControlSingleLine honored paddings. However the testcase expects it ignores paddings.
So, I decided to introduce a special handling for type=search so that only type=search ignores paddings if the content box of <input> is smaller than the text height.