Bug 63152 - runAnimationTest always fails if the pause API is enabled and the test target animation has "infinite" iteration count.
Summary: runAnimationTest always fails if the pause API is enabled and the test target...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-22 10:12 PDT by Young Han Lee
Modified: 2011-06-23 12:11 PDT (History)
4 users (show)

See Also:


Attachments
testcase (1.48 KB, text/html)
2011-06-22 10:12 PDT, Young Han Lee
no flags Details
Patch (1.71 KB, patch)
2011-06-23 07:40 PDT, Young Han Lee
no flags Details | Formatted Diff | Diff
Patch (4.41 KB, patch)
2011-06-23 09:07 PDT, Young Han Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Young Han Lee 2011-06-22 10:12:28 PDT
Created attachment 98195 [details]
testcase

The testcase is a slightly modified version of the LayoutTests/animations/keyframes.html, and the only difference is the animation-iteration-count property.

The result of the testcase :
-PASS - "left" property for "box" element at 0.3s saw something close to: 100
-PASS - "left" property for "box" element at 0.7s saw something close to: 200
+FAIL - animation "anim" is not running
+FAIL - animation "anim" is not running

You can see that any animation test fails if you put a '-webkit-animation-iteration-count: infinite' line to the test.
Comment 1 Young Han Lee 2011-06-23 07:40:29 PDT
Created attachment 98349 [details]
Patch
Comment 2 Young Han Lee 2011-06-23 07:41:38 PDT
The pausing conditions in the pauseAnimationAtTime() was wrong.
Comment 3 Simon Fraser (smfr) 2011-06-23 08:18:59 PDT
Comment on attachment 98349 [details]
Patch

Needs a testcase!
Comment 4 Young Han Lee 2011-06-23 08:44:55 PDT
(In reply to comment #3)
> (From update of attachment 98349 [details])
> Needs a testcase!

Oh, I thought a testcase isn't needed in this case because this is a change for the test framework itself. :)

Okay, new patch will come shortly.
Comment 5 Young Han Lee 2011-06-23 09:07:40 PDT
Created attachment 98356 [details]
Patch
Comment 6 WebKit Review Bot 2011-06-23 12:11:21 PDT
Comment on attachment 98356 [details]
Patch

Clearing flags on attachment: 98356

Committed r89597: <http://trac.webkit.org/changeset/89597>
Comment 7 WebKit Review Bot 2011-06-23 12:11:26 PDT
All reviewed patches have been landed.  Closing bug.