Bug 63151 – WebGL test failing on SL bots: fast/canvas/webgl/data-view-test.html

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Matthew Delaney]

This WebGL test recently started failing on the bots. I looked at it briefly, but realized that the test may need some looking at since the TypeError and SyntaxError messages don't seem to match up. I get the feeling that our expected results file is incorrect and/or the test may need updating to conform with WebIDL.

[Matthew Delaney]

Added a platform/mac expected results file here to keep tree from burning: http://trac.webkit.org/changeset/89450

[Kenneth Russell]

This is likely failing due to http://trac.webkit.org/changeset/89315 . From looking at the Mac specific test expectations, it looks like the test needs a new baseline, but it also looks like there might also be custom bindings that should change from throwing SyntaxError to throwing TypeError.

Jian Li, would you be willing to take this?

[Adam Barth]

Yeah, we change the type of error thrown in this case to match the specs.  Sorry we missed this test result.  Thanks for cleaning up after us.

[Matthew Delaney]

No worries. So, should the platform independent expected result be updated then (and the platform expected results be blown away)? Because mac SL currently fails against the current platform independent result.

I can't wait to have all of these type error issues out of the way.

[Kenneth Russell]

Ideally yes, we should have the same result for all platforms. Hopefully Jian Li can make this work.

[Jian Li]

Created attachment 98438 [details]
Proposed Patch

[Kenneth Russell]

Comment on attachment 98438 [details]
Proposed Patch

It's great that so many duplicated test expectations can be deleted. Did you test on the three affected platforms?

[Jian Li]

Tested on Mac. Will test on Chromium before landing.

[WebKit Review Bot]

Comment on attachment 98438 [details]
Proposed Patch

Attachment 98438 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8933299

New failing tests:
fast/canvas/webgl/data-view-test.html

[WebKit Review Bot]

Created attachment 98450 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Jian Li]

Committed as https://trac.webkit.org/changeset/90046.