Bug 63150 - [UNIX] Increment/decrement module load conter in NetscapePluginModule::getPluginInfo()
Summary: [UNIX] Increment/decrement module load conter in NetscapePluginModule::getPlu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Qt
: 63184 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-06-22 09:54 PDT by Carlos Garcia Campos
Modified: 2011-06-23 10:42 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.98 KB, patch)
2011-06-22 09:56 PDT, Carlos Garcia Campos 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-06-22 09:54:29 PDT 
Since the method is static, we are using NetscapePluginModule::getOrCreate() to get the module. If it's created, the load counter is 0, so that when module is deleted, shutdown() hasn't been called and the destructor crashes in the assert that checks the module has been removed from the initialized module list. We should increment the load counter, and decrement it before getPluginInfo() returns, so that decrementLoadCount() will call shutdown() if counter is 0 and the module will be deleted from the list.
Comment 1 Carlos Garcia Campos 2011-06-22 09:56:36 PDT 
Created attachment 98189 [details]
Patch
Comment 2 Carlos Garcia Campos 2011-06-22 23:47:14 PDT 
Committed r89539: <http://trac.webkit.org/changeset/89539>
Comment 3 Laszlo Gombos 2011-06-23 10:42:40 PDT 
*** Bug 63184 has been marked as a duplicate of this bug. ***