Bug 63146 - Web Inspector: Restore console messages when restoring inspector state
Summary: Web Inspector: Restore console messages when restoring inspector state
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-22 09:14 PDT by Sreeram Ramachandran
Modified: 2011-06-22 12:27 PDT (History)
11 users (show)

See Also:


Attachments
Patch (2.77 KB, patch)
2011-06-22 09:17 PDT, Sreeram Ramachandran
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sreeram Ramachandran 2011-06-22 09:14:39 PDT
When inspector state needs to be restored (e.g.: when the inspected tab is swapped), console messages are not restored. They should be. For reference, other panels (Elements, Resources, etc) are correctly restored.
Comment 1 Sreeram Ramachandran 2011-06-22 09:17:37 PDT
Created attachment 98182 [details]
Patch
Comment 2 Pavel Feldman 2011-06-22 09:22:32 PDT
Comment on attachment 98182 [details]
Patch

We will lose the expiredCount information in this case, so we'll need to fix it further. But this is an incremental improvement, so r+.
Comment 3 WebKit Review Bot 2011-06-22 09:25:06 PDT
Comment on attachment 98182 [details]
Patch

Rejecting attachment 98182 [details] from commit-queue.

sreeram@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 4 WebKit Review Bot 2011-06-22 12:26:58 PDT
Comment on attachment 98182 [details]
Patch

Clearing flags on attachment: 98182

Committed r89456: <http://trac.webkit.org/changeset/89456>
Comment 5 WebKit Review Bot 2011-06-22 12:27:02 PDT
All reviewed patches have been landed.  Closing bug.