Bug 63139 - Web Inspector: extract duplicated code that deals with source mappings.
Summary: Web Inspector: extract duplicated code that deals with source mappings.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-22 07:31 PDT by Pavel Podivilov
Modified: 2011-07-05 06:32 PDT (History)
12 users (show)

See Also:

Attachments
Patch. (11.26 KB, patch)
2011-06-22 07:32 PDT, Pavel Podivilov 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-03 (1.41 MB, application/zip)
2011-06-22 09:02 PDT, WebKit Review Bot 		no flags Details
Build fix. (11.54 KB, patch)
2011-06-23 01:57 PDT, Pavel Podivilov 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-06-22 07:31:59 PDT 
Web Inspector: extract duplicated code that deals with source mappings.
Comment 1 Pavel Podivilov 2011-06-22 07:32:30 PDT 
Created attachment 98170 [details]
Patch.
Comment 2 WebKit Review Bot 2011-06-22 09:02:38 PDT 
Comment on attachment 98170 [details]
Patch.

Attachment 98170 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8923548

New failing tests:
http/tests/inspector/network/x-frame-options-deny.html
http/tests/inspector/console-xhr-logging.html
http/tests/inspector/network-preflight-options.html
Comment 3 WebKit Review Bot 2011-06-22 09:02:44 PDT 
Created attachment 98179 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 Pavel Podivilov 2011-06-23 01:57:26 PDT 
Created attachment 98325 [details]
Build fix.

Console messages sometimes don't have url. We shouldn't try to show such messages in source frame.
Comment 5 Pavel Podivilov 2011-07-05 06:32:20 PDT 
Committed r90395: <http://trac.webkit.org/changeset/90395>