Bug 63138 - Web Inspector: split setAttributes and setAttributeValue.
Summary: Web Inspector: split setAttributes and setAttributeValue.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-22 07:23 PDT by Pavel Feldman
Modified: 2011-06-22 09:25 PDT (History)
10 users (show)

See Also:


Attachments
Patch (12.97 KB, patch)
2011-06-22 08:06 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-06-22 07:23:49 PDT
setAttribute's documentation is confusing. It is actually doing a completely different thing.
Comment 1 Pavel Feldman 2011-06-22 08:06:39 PDT
Created attachment 98173 [details]
Patch
Comment 2 Yury Semikhatsky 2011-06-22 08:40:14 PDT
Comment on attachment 98173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98173&action=review

> Source/WebCore/inspector/Inspector.json:883
> +                    { "name": "text", "type": "string", "description": "Text with a number of attributes. Will parse this text using HTML parser." }

We should be explicit about what should happen to the existing attributes with same names should the text contain such attributes.
Comment 3 Pavel Feldman 2011-06-22 09:25:10 PDT
Committed r89439: <http://trac.webkit.org/changeset/89439>