Bug 63123 - run-webkit-websocketserver fails to stop websocket server
Summary: run-webkit-websocketserver fails to stop websocket server
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-22 02:04 PDT by Yuta Kitamura
Modified: 2011-06-22 12:52 PDT (History)
4 users (show)

See Also:


Attachments
patch that fixes new-run-webkit-websocketserver and also adds better tests (13.51 KB, patch)
2011-06-22 12:24 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
fix rename, update ChangeLog (8.56 KB, patch)
2011-06-22 12:35 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
add dirname back in that was lost in the rename (8.46 KB, patch)
2011-06-22 12:45 PDT, Dirk Pranke
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-06-22 02:04:54 PDT
If you manually run run-webkit-websocketserver, it fails to stop the pywebsocket server and leaks the process. It's probably caused by r89400.

$ Tools/Scripts/run-webkit-websocketserver 
Starting Web Socket server...
Started.
Hit [ENTER] to stop it.
Stopping Web Socket server...
Traceback (most recent call last):
  File "/usr/local/google/home/yutak/build/Chromium/src/third_party/WebKit/Tools/Scripts/new-run-webkit-websocketserver", line 108, in <module>
    main()
  File "/usr/local/google/home/yutak/build/Chromium/src/third_party/WebKit/Tools/Scripts/new-run-webkit-websocketserver", line 105, in main
    pywebsocket.stop(force=True)
TypeError: stop() got an unexpected keyword argument 'force'
Stopped.

$ ps aux |grep pywebsocket
yutak    18693  0.0  0.0  48324  9548 pts/2    S    17:58   0:00 /usr/bin/python -u .../pywebsocket/mod_pywebsocket/standalone.py --server-host 127.0.0.1 --port 8880 ...
yutak    18788  0.0  0.0   6468   900 pts/2    S+   18:02   0:00 grep pywebsocket
Comment 1 Dirk Pranke 2011-06-22 12:24:05 PDT
Created attachment 98212 [details]
patch that fixes new-run-webkit-websocketserver and also adds better tests
Comment 2 Dirk Pranke 2011-06-22 12:25:33 PDT
I've fixed the bug that was causing new-run-webkit-websocketserver to crash, and revamped the integration tests so that we test that script as well as new-run-webkit-httpd .

The naming for the test class is pretty clumsy; I'm open to better ideas, but the important thing to preserve is that testing both scripts is basically identical so we should share the test code as much as possible.
Comment 3 Dirk Pranke 2011-06-22 12:35:58 PDT
Created attachment 98217 [details]
fix rename, update ChangeLog
Comment 4 Dirk Pranke 2011-06-22 12:45:36 PDT
Created attachment 98220 [details]
add dirname back in that was lost in the rename
Comment 5 Dirk Pranke 2011-06-22 12:52:34 PDT
Committed r89459: <http://trac.webkit.org/changeset/89459>