Bug 63122 - MediaStream API: Rename Stream, GeneratedStream and StreamRecorder to the latest spec
Summary: MediaStream API: Rename Stream, GeneratedStream and StreamRecorder to the lat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 56459
  Show dependency tree / graph
 
Reported: 2011-06-22 01:18 PDT by Tommy Widenflycht
Modified: 2011-06-23 08:28 PDT (History)
6 users (show)

See Also:

Attachments
Patch (85.20 KB, patch)
2011-06-23 03:24 PDT, Tommy Widenflycht 		tonyg: review-
gustavo.noronha: commit-queue-
Details | Formatted Diff | Diff
Created by "git diff --no-prefix master..HEAD" (138.54 KB, patch)
2011-06-23 06:00 PDT, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Patch (2.08 KB, patch)
2011-06-23 08:09 PDT, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2011-06-22 01:18:35 PDT 
Rename Stream -> MediaStream, GeneratedStream -> LocalMediaStream and StreamRecorder -> MediaStreamRecorder after whatwg spec change.
Comment 1 Tommy Widenflycht 2011-06-23 03:24:58 PDT 
Created attachment 98331 [details]
Patch
Comment 2 Collabora GTK+ EWS bot 2011-06-23 03:32:15 PDT 
Comment on attachment 98331 [details]
Patch

Attachment 98331 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8924974
Comment 3 Early Warning System Bot 2011-06-23 03:33:28 PDT 
Comment on attachment 98331 [details]
Patch

Attachment 98331 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8932029
Comment 4 WebKit Review Bot 2011-06-23 03:43:00 PDT 
Comment on attachment 98331 [details]
Patch

Attachment 98331 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8932030
Comment 5 Tony Gentilcore 2011-06-23 04:43:32 PDT 
Comment on attachment 98331 [details]
Patch

Will r+ when the EWS bots are happy.
Comment 6 Tommy Widenflycht 2011-06-23 06:00:06 PDT 
Created attachment 98340 [details]
Created by "git diff --no-prefix master..HEAD"
Comment 7 WebKit Review Bot 2011-06-23 07:23:22 PDT 
Comment on attachment 98340 [details]
Created by "git diff --no-prefix master..HEAD"

Rejecting attachment 98340 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1

Last 500 characters of output:
  return self.open(self.click(*args, **kwds))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
    return self._mech_open(url, data, timeout=timeout)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open
    raise response
webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error

Full output: http://queues.webkit.org/results/8933088
Comment 8 Collabora GTK+ EWS bot 2011-06-23 07:25:54 PDT 
Comment on attachment 98340 [details]
Created by "git diff --no-prefix master..HEAD"

Attachment 98340 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8933087
Comment 9 Tommy Widenflycht 2011-06-23 08:09:19 PDT 
Created attachment 98352 [details]
Patch
Comment 10 Tony Gentilcore 2011-06-23 08:17:49 PDT 
Comment on attachment 98352 [details]
Patch

Thanks! In the future please open a separate bug for each patch (you can mark one as blocking the other).
Comment 11 Tommy Widenflycht 2011-06-23 08:20:42 PDT 
(In reply to comment #10)
> (From update of attachment 98352 [details])
> Thanks! In the future please open a separate bug for each patch (you can mark one as blocking the other).

Sorry! Will do this in the future.
Comment 12 WebKit Review Bot 2011-06-23 08:28:00 PDT 
Comment on attachment 98352 [details]
Patch

Clearing flags on attachment: 98352

Committed r89573: <http://trac.webkit.org/changeset/89573>
Comment 13 WebKit Review Bot 2011-06-23 08:28:05 PDT 
All reviewed patches have been landed.  Closing bug.