Bug 63120 - [EFL] Add an option to enable Device Orientation Event.
Summary: [EFL] Add an option to enable Device Orientation Event.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 63125
Blocks:
  Show dependency tree / graph
 
Reported: 2011-06-22 01:00 PDT by Ryuan Choi
Modified: 2011-06-22 18:07 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.59 KB, patch)
2011-06-22 03:05 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (4.59 KB, patch)
2011-06-22 03:33 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2011-06-22 01:00:12 PDT 
Patch will be added.
Comment 1 Ryuan Choi 2011-06-22 03:05:05 PDT 
Created attachment 98145 [details]
Patch
Comment 2 Gyuyoung Kim 2011-06-22 03:23:18 PDT 
Is DeviceOrientation Event specification finalized ?
Comment 3 Gyuyoung Kim 2011-06-22 03:25:01 PDT 
Comment on attachment 98145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98145&action=review

> Source/cmakeconfig.h.cmake:16
> +#cmakedefine01 ENABLE_DEVICE_ORIENTATION

Move above line to ENABLE_DOM_STORAGE
Comment 4 Ryuan Choi 2011-06-22 03:33:27 PDT 
Created attachment 98150 [details]
Patch
Comment 5 Ryuan Choi 2011-06-22 03:36:04 PDT 
(In reply to comment #2)
> Is DeviceOrientation Event specification finalized ?

No, Now is ED.
But I believe that we need to follow it.

(In reply to comment #3)
> (From update of attachment 98145 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98145&action=review
> 
> > Source/cmakeconfig.h.cmake:16
> > +#cmakedefine01 ENABLE_DEVICE_ORIENTATION
> 
> Move above line to ENABLE_DOM_STORAGE

Sorry, I mistake.
Done.
Comment 6 Gyuyoung Kim 2011-06-22 03:48:51 PDT 
(In reply to comment #5)
> (In reply to comment #2)
> > Is DeviceOrientation Event specification finalized ?
> 
> No, Now is ED.
> But I believe that we need to follow it.

Ok, I think this is not bad.
Comment 7 Raphael Kubo da Costa (:rakuco) 2011-06-22 06:00:27 PDT 
Informal r+ from my side.
Comment 8 WebKit Review Bot 2011-06-22 18:07:31 PDT 
Comment on attachment 98150 [details]
Patch

Clearing flags on attachment: 98150

Committed r89509: <http://trac.webkit.org/changeset/89509>
Comment 9 WebKit Review Bot 2011-06-22 18:07:36 PDT 
All reviewed patches have been landed.  Closing bug.