WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
63120
[EFL] Add an option to enable Device Orientation Event.
https://bugs.webkit.org/show_bug.cgi?id=63120
Summary
[EFL] Add an option to enable Device Orientation Event.
Ryuan Choi
Reported
2011-06-22 01:00:12 PDT
Patch will be added.
Attachments
Patch
(4.59 KB, patch)
2011-06-22 03:05 PDT
,
Ryuan Choi
no flags
Details
Formatted Diff
Diff
Patch
(4.59 KB, patch)
2011-06-22 03:33 PDT
,
Ryuan Choi
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ryuan Choi
Comment 1
2011-06-22 03:05:05 PDT
Created
attachment 98145
[details]
Patch
Gyuyoung Kim
Comment 2
2011-06-22 03:23:18 PDT
Is DeviceOrientation Event specification finalized ?
Gyuyoung Kim
Comment 3
2011-06-22 03:25:01 PDT
Comment on
attachment 98145
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=98145&action=review
> Source/cmakeconfig.h.cmake:16 > +#cmakedefine01 ENABLE_DEVICE_ORIENTATION
Move above line to ENABLE_DOM_STORAGE
Ryuan Choi
Comment 4
2011-06-22 03:33:27 PDT
Created
attachment 98150
[details]
Patch
Ryuan Choi
Comment 5
2011-06-22 03:36:04 PDT
(In reply to
comment #2
)
> Is DeviceOrientation Event specification finalized ?
No, Now is ED. But I believe that we need to follow it. (In reply to
comment #3
)
> (From update of
attachment 98145
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=98145&action=review
> > > Source/cmakeconfig.h.cmake:16 > > +#cmakedefine01 ENABLE_DEVICE_ORIENTATION > > Move above line to ENABLE_DOM_STORAGE
Sorry, I mistake. Done.
Gyuyoung Kim
Comment 6
2011-06-22 03:48:51 PDT
(In reply to
comment #5
)
> (In reply to
comment #2
) > > Is DeviceOrientation Event specification finalized ? > > No, Now is ED. > But I believe that we need to follow it.
Ok, I think this is not bad.
Raphael Kubo da Costa (:rakuco)
Comment 7
2011-06-22 06:00:27 PDT
Informal r+ from my side.
WebKit Review Bot
Comment 8
2011-06-22 18:07:31 PDT
Comment on
attachment 98150
[details]
Patch Clearing flags on attachment: 98150 Committed
r89509
: <
http://trac.webkit.org/changeset/89509
>
WebKit Review Bot
Comment 9
2011-06-22 18:07:36 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug