Bug 63113 - [Qt] Add a build flag for building with libxml2 and libxslt.
Summary: [Qt] Add a build flag for building with libxml2 and libxslt.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-21 20:17 PDT by Yael
Modified: 2019-05-03 01:31 PDT (History)
5 users (show)

See Also:

Attachments
Patch. (6.69 KB, patch)
2011-06-21 20:25 PDT, Yael 		kling: review+
kling: commit-queue-
Details | Formatted Diff | Diff
Patch. (6.74 KB, patch)
2011-06-22 17:19 PDT, Yael 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2011-06-21 20:17:59 PDT 
QtWebKit should have a build option for building with libxml2 and libxslt instead of Qt's own libraries.
Comment 1 Yael 2011-06-21 20:25:56 PDT 
Created attachment 98110 [details]
Patch.

If this build flag was enabled by default, this would fix
https://bugs.webkit.org/show_bug.cgi?id=55302
https://bugs.webkit.org/show_bug.cgi?id=37445

and xmlviewer tests could be unskipped.
Comment 2 Yael 2011-06-21 20:28:02 PDT 
This patch assumes that enabling the flag WTF_USE_LIBXML2 automatically enables also ENABLE_XSLT, but it does not have to be that way.
Comment 3 Andreas Kling 2011-06-22 13:56:09 PDT 
Comment on attachment 98110 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=98110&action=review

> Source/WebCore/CodeGenerators.pri:28
> +

Unnecessary newline!

> Source/WebCore/features.pri:131
>  
> +contains(DEFINES, WTF_USE_LIBXML2=1) {

Add a comment saying this is experimental and only works on Linux so far.
Comment 4 Yael 2011-06-22 17:19:37 PDT 
Created attachment 98268 [details]
Patch.

Update with Kling's last comments.
Comment 5 WebKit Review Bot 2011-06-22 18:36:54 PDT 
Comment on attachment 98268 [details]
Patch.

Clearing flags on attachment: 98268

Committed r89516: <http://trac.webkit.org/changeset/89516>
Comment 6 WebKit Review Bot 2011-06-22 18:36:59 PDT 
All reviewed patches have been landed.  Closing bug.