Bug 63107 - Make sheriff-bot rollout messages a little nicer
Summary: Make sheriff-bot rollout messages a little nicer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-21 17:36 PDT by Eric Seidel (no email)
Modified: 2011-06-22 19:14 PDT (History)
6 users (show)

See Also:

Attachments
Patch (14.48 KB, patch)
2011-06-21 17:44 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch (1.56 KB, patch)
2011-06-22 18:24 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-06-21 17:36:56 PDT 
Make sheriff-bot rollout messages a little nicer
Comment 1 Eric Seidel (no email) 2011-06-21 17:44:05 PDT 
Created attachment 98087 [details]
Patch
Comment 2 Ojan Vafai 2011-06-21 18:50:35 PDT 
Comment on attachment 98087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98087&action=review

> Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:82
> +        # When folks pass junk arguments, we should just spit the usage back at them.

This comment doesn't seem helpful.

> Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:89
> +        # FIXME: I'm slightly confused as to why this doesn't return the USAGE message.

It's not clear from the USAGE message that you can't begin your rollout description with a dash.
Comment 3 Eric Seidel (no email) 2011-06-22 14:04:25 PDT 
Comment on attachment 98087 [details]
Patch

Thank you for the review.  I'm going to land it as is and iterate based on any further feedback from users.
Comment 4 WebKit Review Bot 2011-06-22 14:33:48 PDT 
Comment on attachment 98087 [details]
Patch

Clearing flags on attachment: 98087

Committed r89480: <http://trac.webkit.org/changeset/89480>
Comment 5 WebKit Review Bot 2011-06-22 14:33:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 David Levin 2011-06-22 18:18:15 PDT 
This change is causing failures on Leopard bots (maybe because they use Python 2.5?): http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/31597/steps/webkitpy-test/logs/stdio
Comment 7 Eric Seidel (no email) 2011-06-22 18:22:06 PDT 
Sigh, yes from_iterable is new in 2.6:
http://docs.python.org/library/itertools.html#itertools.chain.from_iterable
Comment 8 Eric Seidel (no email) 2011-06-22 18:22:55 PDT 
Fixing now.
Comment 9 Eric Seidel (no email) 2011-06-22 18:24:38 PDT 
Created attachment 98283 [details]
Patch
Comment 10 Eric Seidel (no email) 2011-06-22 18:31:00 PDT 
We need to make webkit-patch upload re-open patches when you attach a new patch. :(
Comment 11 WebKit Review Bot 2011-06-22 19:14:43 PDT 
Comment on attachment 98283 [details]
Patch

Clearing flags on attachment: 98283

Committed r89520: <http://trac.webkit.org/changeset/89520>
Comment 12 WebKit Review Bot 2011-06-22 19:14:48 PDT 
All reviewed patches have been landed.  Closing bug.