Bug 63106 - Removed the conceit that global variables are local variables when running global code
Summary: Removed the conceit that global variables are local variables when running gl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-21 16:50 PDT by Geoffrey Garen
Modified: 2011-06-22 13:25 PDT (History)
2 users (show)

See Also:


Attachments
Patch (38.34 KB, patch)
2011-06-21 17:15 PDT, Geoffrey Garen
oliver: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-06-21 16:50:41 PDT
Removed the conceit that global variables are local variables when running global code
Comment 1 Geoffrey Garen 2011-06-21 17:15:55 PDT
Created attachment 98084 [details]
Patch
Comment 2 WebKit Review Bot 2011-06-21 17:18:09 PDT
Attachment 98084 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/JavaScriptCore/interpreter/RegisterFile.h:40:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2011-06-21 17:26:28 PDT
Comment on attachment 98084 [details]
Patch

Attachment 98084 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8926076
Comment 4 Geoffrey Garen 2011-06-21 17:30:11 PDT
Not sure what the Qt failure is about -- seems like the bot is in a bad state?
Comment 5 Darin Adler 2011-06-21 17:35:03 PDT
Comment on attachment 98084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98084&action=review

> Source/JavaScriptCore/interpreter/RegisterFile.h:-36
> -#include <stdio.h>

Looks like WebFrameProxy.cpp in WebKit2 was depending on this include to get the printf prototype.
Comment 6 Oliver Hunt 2011-06-21 17:35:47 PDT
Comment on attachment 98084 [details]
Patch

r=me, it would be good if you could add helper function to JSGlobalObject to add new global vars directly.
Comment 7 Geoffrey Garen 2011-06-22 13:25:27 PDT
http://trac.webkit.org/changeset/89465