Removed the conceit that global variables are local variables when running global code
Created attachment 98084 [details] Patch
Attachment 98084 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/JavaScriptCore/interpreter/RegisterFile.h:40: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 98084 [details] Patch Attachment 98084 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8926076
Not sure what the Qt failure is about -- seems like the bot is in a bad state?
Comment on attachment 98084 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98084&action=review > Source/JavaScriptCore/interpreter/RegisterFile.h:-36 > -#include <stdio.h> Looks like WebFrameProxy.cpp in WebKit2 was depending on this include to get the printf prototype.
Comment on attachment 98084 [details] Patch r=me, it would be good if you could add helper function to JSGlobalObject to add new global vars directly.
http://trac.webkit.org/changeset/89465