Bug 63095 - [Qt] Add an API for accessing the QGraphicsView.
Summary: [Qt] Add an API for accessing the QGraphicsView.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-21 14:04 PDT by Yael
Modified: 2011-06-21 14:34 PDT (History)
0 users

See Also:

Attachments
Patch. (1.80 KB, patch)
2011-06-21 14:09 PDT, Yael 		kenneth: review+
kenneth: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2011-06-21 14:04:17 PDT 
This was requested by 2 reviewers in https://bugs.webkit.org/show_bug.cgi?id=62838.
Comment 1 Yael 2011-06-21 14:09:05 PDT 
Created attachment 98055 [details]
Patch.
Comment 2 Kenneth Rohde Christiansen 2011-06-21 14:12:47 PDT 
Comment on attachment 98055 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=98055&action=review

> Source/WebKit2/ChangeLog:5
> +        [Qt] Add an API for accessing the QGraphicsView.

internal API*

> Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:316
> +    if (views.size() > 1)
> +        qWarning("Cannot support multiple views");

Not sure this is the right way to handle it, but I guess it is fine.
Comment 3 Yael 2011-06-21 14:20:58 PDT 
(In reply to comment #2)
> (From update of attachment 98055 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98055&action=review
> 
> > Source/WebKit2/ChangeLog:5
> > +        [Qt] Add an API for accessing the QGraphicsView.
> 
> internal API*
> 
> > Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:316
> > +    if (views.size() > 1)
> > +        qWarning("Cannot support multiple views");
> 
> Not sure this is the right way to handle it, but I guess it is fine.

Thank you for reviewing :)
Comment 4 Yael 2011-06-21 14:34:13 PDT 
Committed r89384: <http://trac.webkit.org/changeset/89384>