Bug 63094 – webkit-patch gets confused by multiple values for bugzilla.username

• Status: NEW
• Component: Tools / Tests

[Eric Seidel (no email)]

webkit-patch gets confused if git local and global usernames are different

% git config --global bugzilla.username
[e-mail]

% git config bugzilla.username
[e-mail]

When I run webkit-patch patches-to-review (or any other command which uses authentication).  This is what I see:

Logging in as [e-mail]
[e-mail]...
Bugzilla login failed: Invalid Username or Password.

I think that the problem is the --get-all:

    @classmethod
    def read_git_config(cls, key, cwd=None):
        # FIXME: This should probably use cwd=self.checkout_root.
        # Pass --get-all for cases where the config has multiple values
        # Pass the cwd if provided so that we can handle the case of running webkit-patch outside of the working directory.
        return run_command(["git", "config", "--get-all", key], error_handler=Executive.ignore_error, cwd=cwd).rstrip('\n')

I suspect we're not expecting to actually get more than one value back from git config.