RESOLVED FIXED 63087
IndexedDB: IDBObjectStore methods should throw TypeError if required arguments are missing 
https://bugs.webkit.org/show_bug.cgi?id=63087
Summary IndexedDB: IDBObjectStore methods should throw TypeError if required argument...
Mark Pilgrim (Google)
Reported 2011-06-21 12:45:12 PDT
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#idl-def-IDBObjectStore lists required arguments to put(), add(), delete(), get(), createIndex(), index(), and deleteIndex(). As per the WebIDL spec, calling functions with missing required arguments should throw a TypeError. This test calls these functions with no arguments, or with too few arguments, to see what happens. Expected behavior: throw TypeError Actual behavior: no exception thrown Patch included. The fix is to remove the LegacyDefaultOptionalArguments flag from IDBObjectStore.idl, which will force the code generator to check for required arguments and throw TypeError when they are missing.
Attachments
Patch (6.09 KB, patch)
2011-06-21 12:48 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2011-06-21 12:48:13 PDT
Created attachment 98045 [details] Patch
Adam Barth
Comment 2 2011-06-21 13:45:34 PDT
Comment on attachment 98045 [details] Patch These patches are so beautiful. Thanks!
WebKit Review Bot
Comment 3 2011-06-21 14:20:27 PDT
Comment on attachment 98045 [details] Patch Clearing flags on attachment: 98045 Committed r89383: <http://trac.webkit.org/changeset/89383>
WebKit Review Bot
Comment 4 2011-06-21 14:20:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.