Bug 63086 - [EFL] DRT: Add DumpRenderTreeView, an ewk_view specialization for DRT
Summary: [EFL] DRT: Add DumpRenderTreeView, an ewk_view specialization for DRT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 62034
  Show dependency tree / graph
 
Reported: 2011-06-21 12:21 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2011-06-27 08:12 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.01 KB, patch)
2011-06-21 12:21 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
New patch following Kent's suggestions (5.97 KB, patch)
2011-06-27 07:24 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2011-06-21 12:21:11 PDT 
[EFL] DRT: Add DumpRenderTreeView, an ewk_view specialization for DRT
Comment 1 Raphael Kubo da Costa (:rakuco) 2011-06-21 12:21:41 PDT 
Created attachment 98038 [details]
Patch
Comment 2 Kent Tamura 2011-06-23 02:27:47 PDT 
Comment on attachment 98038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98038&action=review

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:38
> +static void onConsoleMessage(Ewk_View_Smart_Data* sd, const char* message, unsigned int lineNumber, const char* sourceID)

'sd' isn't a good name.
Also, we don't need to write argument names if they aren't used in the function body.

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:43
> +static void onJavaScriptAlert(Ewk_View_Smart_Data* sd, Evas_Object* frame, const char* message)

ditto.

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:48
> +static Eina_Bool onJavaScriptConfirm(Ewk_View_Smart_Data* sd, Evas_Object* frame, const char* message)

ditto.

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:54
> +static Eina_Bool onJavaScriptPrompt(Ewk_View_Smart_Data* sd, Evas_Object* frame, const char* message, const char* defaultValue, char** value)

ditto.

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:61
> +Evas_Object* drtViewTiledAdd(Evas* e)

'e' is not a good name.
Comment 3 Raphael Kubo da Costa (:rakuco) 2011-06-27 07:24:54 PDT 
Created attachment 98720 [details]
New patch following Kent's suggestions
Comment 4 Raphael Kubo da Costa (:rakuco) 2011-06-27 07:25:44 PDT 
CC'ing Kent after a new patch was added after his suggestions.
Comment 5 Kent Tamura 2011-06-27 07:30:55 PDT 
Comment on attachment 98720 [details]
New patch following Kent's suggestions

Rubber-stamped by me.
Comment 6 WebKit Review Bot 2011-06-27 08:12:41 PDT 
Comment on attachment 98720 [details]
New patch following Kent's suggestions

Clearing flags on attachment: 98720

Committed r89821: <http://trac.webkit.org/changeset/89821>
Comment 7 WebKit Review Bot 2011-06-27 08:12:46 PDT 
All reviewed patches have been landed.  Closing bug.