Bug 63086 – [EFL] DRT: Add DumpRenderTreeView, an ewk_view specialization for DRT

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Raphael Kubo da Costa (:rakuco)]

[EFL] DRT: Add DumpRenderTreeView, an ewk_view specialization for DRT

[Raphael Kubo da Costa (:rakuco)]

Created attachment 98038 [details]
Patch

[Kent Tamura]

Comment on attachment 98038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98038&action=review

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:38
> +static void onConsoleMessage(Ewk_View_Smart_Data* sd, const char* message, unsigned int lineNumber, const char* sourceID)

'sd' isn't a good name.
Also, we don't need to write argument names if they aren't used in the function body.

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:43
> +static void onJavaScriptAlert(Ewk_View_Smart_Data* sd, Evas_Object* frame, const char* message)

ditto.

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:48
> +static Eina_Bool onJavaScriptConfirm(Ewk_View_Smart_Data* sd, Evas_Object* frame, const char* message)

ditto.

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:54
> +static Eina_Bool onJavaScriptPrompt(Ewk_View_Smart_Data* sd, Evas_Object* frame, const char* message, const char* defaultValue, char** value)

ditto.

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:61
> +Evas_Object* drtViewTiledAdd(Evas* e)

'e' is not a good name.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 98720 [details]
New patch following Kent's suggestions

[Raphael Kubo da Costa (:rakuco)]

CC'ing Kent after a new patch was added after his suggestions.

[Kent Tamura]

Comment on attachment 98720 [details]
New patch following Kent's suggestions

Rubber-stamped by me.

[WebKit Review Bot]

Comment on attachment 98720 [details]
New patch following Kent's suggestions

Clearing flags on attachment: 98720

Committed r89821: <http://trac.webkit.org/changeset/89821>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.