Bug 63080 – Unit-tests step on test-only bot is broken

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dmitry Lomov]

Removing the step until run-api-tests is fixed

[Dmitry Lomov]

Created attachment 98013 [details]
Fix

[Adam Roben (:aroben)]

Comment on attachment 98013 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=98013&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-564
> -        # FIXME: Only running in debug mode due to https://bugs.webkit.org/show_bug.cgi?id=61812
> -        if configuration == "debug":
> -            self.addStep(RunUnitTests)

Presumably BuildAndTestFactory doesn't need this fix?

[Adam Roben (:aroben)]

Comment on attachment 98013 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=98013&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-564
>> -            self.addStep(RunUnitTests)
> 
> Presumably BuildAndTestFactory doesn't need this fix?

Indeed, SnowLeopard Intel Leaks (which uses BuildAndTestFactory) doesn't show the issue you're trying to fix: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/17616/steps/run-api-tests/logs/stdio

[Dmitry Lomov]

(In reply to comment #3)
> (From update of attachment 98013 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98013&action=review
> 
> >> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-564
> >> -            self.addStep(RunUnitTests)
> > 
> > Presumably BuildAndTestFactory doesn't need this fix?
> 
> Indeed, SnowLeopard Intel Leaks (which uses BuildAndTestFactory) doesn't show the issue you're trying to fix: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/17616/steps/run-api-tests/logs/stdio

Cool - I'll be back :)

[Dmitry Lomov]

Created attachment 98030 [details]
Not disabling on build-and-test bots; disabling on non-(win and mac)

[Adam Roben (:aroben)]

Comment on attachment 98030 [details]
Not disabling on build-and-test bots; disabling on non-(win and mac)

View in context: https://bugs.webkit.org/attachment.cgi?id=98030&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:559
> +        if configuration == "debug" and (platform == 'mac' or platform == 'win'):

An even better way to write this is:

if configuration == 'debug' and platform in ('mac', 'win'):

[WebKit Review Bot]

Comment on attachment 98030 [details]
Not disabling on build-and-test bots; disabling on non-(win and mac)

Clearing flags on attachment: 98030

Committed r89373: <http://trac.webkit.org/changeset/89373>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.