RESOLVED DUPLICATE of bug 6305463053
IndexedDB: createObjectStore() should check if keypath is valid 
https://bugs.webkit.org/show_bug.cgi?id=63053
Summary IndexedDB: createObjectStore() should check if keypath is valid
Kentaro Hara
Reported 2011-06-21 00:34:55 PDT
The spec (http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBDatabase-createObjectStore-IDBObjectStore-DOMString-name-Object-optionalParameters) says "If keyPath is an array and any items in the array is not a valid key path, or if keyPath is a string and is not a valid key path then a NON_TRANSIENT_ERR error must be thrown". However, the current createObjectStore() does not check the keypath argument and thus it does not throw any exception when we give an invalid keypath. I attached the test case that should throw an exception.
Attachments
Add attachment proposed patch, testcase, etc.
Robin Qiu
Comment 1 2011-08-06 05:58:10 PDT
Forgot to attach the test case?
Robin Qiu
Comment 2 2011-08-06 06:09:02 PDT
This bug was fixed, in commit 63663e38. 85 63663e38 Source/WebCore/storage/IDBDatabase.cpp (commit-queue@webkit.org 2011-06-22 20:09:05 +0000 85) if (!IDBIsValidKeyPath(keyPath)) { 86 63663e38 Source/WebCore/storage/IDBDatabase.cpp (commit-queue@webkit.org 2011-06-22 20:09:05 +0000 86) ec = IDBDatabaseException::NON_TRANSIENT_ERR; 87 63663e38 Source/WebCore/storage/IDBDatabase.cpp (commit-queue@webkit.org 2011-06-22 20:09:05 +0000 87) return 0; 88 63663e38 Source/WebCore/storage/IDBDatabase.cpp (commit-queue@webkit.org 2011-06-22 20:09:05 +0000 88) } 89 63663e38 Source/WebCore/storage/IDBDatabase.cpp (commit-queue@webkit.org 2011-06-22 20:09:05 +0000 89)
Robin Qiu
Comment 3 2011-08-06 06:18:42 PDT
Duplicate bug, see bug 63054.
Joshua Bell
Comment 4 2011-10-14 13:42:32 PDT
*** This bug has been marked as a duplicate of bug 63054 ***
Note You need to log in before you can comment on or make changes to this bug.