Bug 63050 – [chromium] cannot replace a misspelled phrase with a suggested word

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Hironori Bono]

(Copied from <http://crbug.com/86905>.)

What steps will reproduce the problem?
1. Open the attached file "replace.html". (Chrome shows a user-added marker under a phrase 'mer ger'.)
2. Right-click the phrase. (Chrome shows a user-added suggestion 'merger' as shown in the attached picture '001.png'.)
3. Choose the suggestion.

What is the expected output?
a misspelled phrase 'mer ger' is replaced with the suggestion 'merger'.

What do you see instead?
a part of the misspelled phrase is replaced with the suggestion as shown in the attached picture '002.png'.

Please use labels and text to provide additional information.
WebFrameImpl::replaceSelection() of Chrome just replaces the selection with the given text and this problem happens when this selection is not equal to the one of a user-added marker. We need to replace the range of a user-added marker with the given text for this case.

Regards,

Hironori Bono

[Hironori Bono]

Created attachment 97951 [details]
A patch v0

Greetings,

I have written a quick fix for Chromium. It may be better to change SpellingCorrectionCommand so it works not only on Chromium but also on other platforms?

Regards,

Hironori Bono

[WebKit Review Bot]

Attachment 97951 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/edit..." exit_code: 1

Source/WebKit/chromium/src/WebFrameImpl.cpp:133:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Hajime Morrita]

Comment on attachment 97951 [details]
A patch v0

View in context: https://bugs.webkit.org/attachment.cgi?id=97951&action=review

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1148
>  }

As you said, I believe this is worth having inside WebCore.
If we have this inside WebCore, we no longer need new TextInputController method.
Also, this behavior is desirable for spelling marker in general, not only for API-based spellchecking.

> LayoutTests/editing/spelling/spellcheck-api-replace.html:7
> +<script language="javascript" type="text/javascript">

Could you get these two <script> block together?

> LayoutTests/editing/spelling/spellcheck-api-replace.html:18
> +function RunTest() {

we usually use camel case name like "runTest"

[Hajime Morrita]

Comment on attachment 97951 [details]
A patch v0

Marking obsolete at now. because original change was gone.