Bug 63047 - [GTK] Switch to GTK+ 3.x by default
Summary: [GTK] Switch to GTK+ 3.x by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks: 62749
  Show dependency tree / graph
 
Reported: 2011-06-20 23:55 PDT by Carlos Garcia Campos
Modified: 2011-08-25 22:35 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.29 KB, patch)
2011-06-24 15:30 PDT, Martin Robinson 		xan.lopez: review+
gustavo.noronha: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-06-20 23:55:01 PDT 
A lot of layout tests give slightly different results with gtk3, so it requires new test results too.
Comment 1 Martin Robinson 2011-06-24 15:30:37 PDT 
Created attachment 98552 [details]
Patch
Comment 2 Martin Robinson 2011-06-24 16:20:23 PDT 
I will take care of updating the expected results when landing this patch.
Comment 3 Collabora GTK+ EWS bot 2011-06-24 18:37:09 PDT 
Comment on attachment 98552 [details]
Patch

Attachment 98552 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8935577
Comment 4 Gustavo Noronha (kov) 2011-07-11 08:00:56 PDT 
I installed GTK+ 3 and gail 3 on the EWS now, and will do on the 32bits buildbot in a second, so future versions of this patch should pass and when it's landed it should build fine on the release buildbot. I think it'd be good to make this switch soon, just let me know when you're planning to and we'll coordinate. The versions I'm installing:

libgtk-3-dev and libgail-3-dev 3.0.10-1
Comment 5 Xan Lopez 2011-08-23 09:27:58 PDT 
Comment on attachment 98552 [details]
Patch

After careful deliberation I believe this patch to be correct.
Comment 6 Martin Robinson 2011-08-25 22:35:33 PDT 
Committed r93852: <http://trac.webkit.org/changeset/93852>