Bug 63031 – Web Inspector: Chromium layout test failure after r89317

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Kenneth Russell]

r89317 has introduced a Chromium layout test failure due to the presence of absolute paths in the "sourceName" property in the events being fired. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&group=%40ToT%20-%20chromium.org&tests=inspector%2Felements%2Fevent-listener-sidebar.html .

[Joseph Pecoraro]

Wow. I really should have noticed that before I landed it.
I will try making the test smarter about this for v8.

[Joseph Pecoraro]

Created attachment 97902 [details]
[PATCH] Possible Solution - Filter the sourceName output, but still test it

Possible fix. I don't have a chromium checkout to test this though,
so I'll try and see what the EWS bots say. Also, if ports use differing
output, say backslashes instead of forward slashes in paths, then
we might need to do even more work or just provide blander output.

[Joseph Pecoraro]

Created attachment 97903 [details]
[PATCH] Possible Solution - Filter the sourceName output, but still test it

Fixup.

[Joseph Pecoraro]

Kenneth skipped this test for chromium (test_expections.txt) in:
<http://trac.webkit.org/changeset/89329>

As such, a new patch would need to be added to unskip the test
at the same time as fixing the output.

I'd like to unskip it soon. I'll try pinging some of the Chromium
developers tomorrow (already CC'd), to see if they can test the patch,
or suggest a more general solution. I can safely provide a solution
that skips the property, or has simple output. However, I figured this
approach would be best, because it also does some testing of the
output of sourceName.

[Joseph Pecoraro]

To anyone willing to try the patch yourself, it doesn't require a rebuild
if you've built since r89317! =)

[Pavel Feldman]

Comment on attachment 97903 [details]
[PATCH] Possible Solution - Filter the sourceName output, but still test it

View in context: https://bugs.webkit.org/attachment.cgi?id=97903&action=review

> LayoutTests/platform/chromium/inspector/elements/event-listener-sidebar-expected.txt:-11
> -    sourceName: file:///mnt/git/webkit-commit-queue/LayoutTests/inspector/elements/event-listener-sidebar.html

So you thought we all share same /mnt/git path in Chromium? :)

[Pavel Feldman]

Committed r89347: <http://trac.webkit.org/changeset/89347>