Bug 63016 - New test for patch introduced in r89250
Summary: New test for patch introduced in r89250
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-20 14:51 PDT by Stephen White
Modified: 2011-06-21 06:50 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.94 KB, patch)
2011-06-20 14:52 PDT, Stephen White
no flags Details | Formatted Diff | Diff
Make pixel test more lenient so it passes on mac (2.99 KB, patch)
2011-06-20 15:48 PDT, Stephen White
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2011-06-20 14:51:41 PDT
New test for patch introduced in r89250
Comment 1 Stephen White 2011-06-20 14:52:50 PDT
Created attachment 97860 [details]
Patch
Comment 2 Stephen White 2011-06-20 15:48:59 PDT
Created attachment 97876 [details]
Make pixel test more lenient so it passes on mac
Comment 3 James Robinson 2011-06-20 16:39:48 PDT
Comment on attachment 97876 [details]
Make pixel test more lenient so it passes on mac

R=me
Comment 4 Alexey Proskuryakov 2011-06-20 20:50:09 PDT
Comment on attachment 97876 [details]
Make pixel test more lenient so it passes on mac

View in context: https://bugs.webkit.org/attachment.cgi?id=97876&action=review

> LayoutTests/ChangeLog:10
> +        * fast/canvas/script-tests/text-globalAlpha.js: Added.
> +        * fast/canvas/text-globalAlpha-expected.txt: Added.
> +        * fast/canvas/text-globalAlpha.html: Added.

Please avoid splitting tests into multiple files.
Comment 5 James Robinson 2011-06-20 22:08:13 PDT
That's the standard way of doing script tests.
Comment 6 Stephen White 2011-06-21 06:48:59 PDT
> (From update of attachment 97876 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97876&action=review
> 
> > LayoutTests/ChangeLog:10
> > +        * fast/canvas/script-tests/text-globalAlpha.js: Added.
> > +        * fast/canvas/text-globalAlpha-expected.txt: Added.
> > +        * fast/canvas/text-globalAlpha.html: Added.
> 
> Please avoid splitting tests into multiple files.

(In reply to comment #5)
> That's the standard way of doing script tests.

Yes, I based it off existing tests.  That said, the HTML is fairly boilerplate between these script tests, differing only in the line which pulls in the JS.  I wonder if there's a way to share more code.
Comment 7 Stephen White 2011-06-21 06:50:12 PDT
Committed r89351: <http://trac.webkit.org/changeset/89351>