Bug 63012 - HTTP pipelining functions on mac should match windows
Summary: HTTP pipelining functions on mac should match windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-20 14:24 PDT by Pratik Solanki
Modified: 2011-06-20 15:46 PDT (History)
3 users (show)

See Also:


Attachments
Patch (760.26 KB, patch)
2011-06-20 15:03 PDT, Pratik Solanki
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2011-06-20 14:24:38 PDT
The definitions for pipelining functions (WKGetHTTPPipeliningPriority and WKSetHTTPPipeliningPriority) take an NSURLRequest on Mac and a CFURLRequest on Windows. We should match the 2 and just use CFURLRequestRef on Mac. This will help bug 51836.
Comment 1 Pratik Solanki 2011-06-20 15:03:10 PDT
Created attachment 97866 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2011-06-20 15:23:48 PDT
Comment on attachment 97866 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97866&action=review

r=me

> Source/WebCore/platform/mac/WebCoreSystemInterface.h:195
> -extern void (*wkSetHTTPPipeliningPriority)(NSMutableURLRequest *, int priority);
> +extern void (*wkSetHTTPPipeliningPriority)(CFURLRequestRef, int priority);

Thank you for cleaning that up for me.  :)
Comment 3 Pratik Solanki 2011-06-20 15:46:05 PDT
Committed r89300: <http://trac.webkit.org/changeset/89300>