Bug 6301 - REGRESSION: Border repaint glitch
Summary: REGRESSION: Border repaint glitch
Status: VERIFIED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-30 04:14 PST by mitz
Modified: 2006-01-31 21:20 PST (History)
0 users

See Also:


Attachments
testcase (880 bytes, text/html)
2005-12-30 04:15 PST, mitz
no flags Details
Repaint moving border (4.51 KB, patch)
2005-12-30 05:37 PST, mitz
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2005-12-30 04:14:56 PST
Summary: fieldsets don't repaint completely when their size changes, so parts of their border are either 
missing or left behind.

To reproduce: open the testcase in Safari. Click each Test button once.

Expected: the bottom border to be painted correctly after resize.

Actual: in the top case (shrinking), a segment is missing on each side of the bottom border; in the bottom 
case (growing), a segment from each side of the bottom border remains behind.
Comment 1 mitz 2005-12-30 04:15:30 PST
Created attachment 5377 [details]
testcase
Comment 2 mitz 2005-12-30 04:21:16 PST
Actually, this is a problem with borders in general, a DIV with solid border works just as well in the 
testcase.
Comment 3 mitz 2005-12-30 05:37:01 PST
Created attachment 5380 [details]
Repaint moving border

Like with bug 5699, an automatic test is currently impossible.
Comment 4 Darin Adler 2005-12-30 11:30:39 PST
Comment on attachment 5380 [details]
Repaint moving border

What about borderLeft/Top?
Comment 5 mitz 2005-12-30 11:44:16 PST
(In reply to comment #4)

> What about borderLeft/Top?

The left/top borders don't move so there's no need to repaint them. You're in this case:
        // We didn't move, but we did change size.  Invalidate the delta, which will consist of possibly 
        // two rectangles (but typically only one).
You only need to extend this to include the area that was/will be occupied by the border that moves.
Comment 6 Darin Adler 2005-12-30 13:30:40 PST
Comment on attachment 5380 [details]
Repaint moving border

r=me
Comment 7 Joost de Valk (AlthA) 2006-01-22 04:56:50 PST
Removing keyword(s) since bug is fixed.
Comment 8 Joost de Valk (AlthA) 2006-01-22 05:01:12 PST
Removing keyword(s) since bug is fixed.
Comment 9 Eric Seidel (no email) 2006-01-31 21:20:52 PST
Removing Regression keyword from bugs already fixed.