Bug 63007 - Web Inspector: Show "no content" message in network panel when resource does not have content available.
Summary: Web Inspector: Show "no content" message in network panel when resource does ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-20 13:17 PDT by Vsevolod Vlasov
Modified: 2011-06-23 08:56 PDT (History)
11 users (show)

See Also:

Attachments
Patch (24.34 KB, patch)
2011-06-20 13:23 PDT, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch with fixes (26.27 KB, patch)
2011-06-21 05:26 PDT, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-06-20 13:17:51 PDT 
Show "no content" message in network panel when resource does not have content available.
Comment 1 Vsevolod Vlasov 2011-06-20 13:23:19 PDT 
Created attachment 97850 [details]
Patch
Comment 2 Yury Semikhatsky 2011-06-21 02:28:35 PDT 
Comment on attachment 97850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97850&action=review

The change looks good except the code duplication in _ensureInnerViewShown

> Source/WebCore/inspector/front-end/ResourceResponseView.js:34
> +    

Remove extra line.

> Source/WebCore/inspector/front-end/ResourceResponseView.js:56
> +    _ensureInnerViewShown: function()

This method is very similar to ResourcePreviewView.prototype._ensureInnerViewShown above could you factor out common code into a new method/class and use it from both places?
Comment 3 Vsevolod Vlasov 2011-06-21 05:26:44 PDT 
Created attachment 97969 [details]
Patch with fixes
Comment 4 WebKit Review Bot 2011-06-23 08:56:19 PDT 
Comment on attachment 97969 [details]
Patch with fixes

Clearing flags on attachment: 97969

Committed r89577: <http://trac.webkit.org/changeset/89577>
Comment 5 WebKit Review Bot 2011-06-23 08:56:24 PDT 
All reviewed patches have been landed.  Closing bug.