RESOLVED FIXED 62996
Web Inspector: console messages shouldn't prevent garbage collection of iframes 
https://bugs.webkit.org/show_bug.cgi?id=62996
Summary Web Inspector: console messages shouldn't prevent garbage collection of iframes
Yury Semikhatsky
Reported 2011-06-20 09:30:09 PDT
Web Inspector: console messages shouldn't prevent garbage collection of iframes. At the moment each console message which has JS arguments will keep strong references to all its arguments and to the corresponding ScriptState. Also InjectedScriptManager keeps reference to all created InjectedScripts until main frame navigation. We should release mentioned ScriptStates and argument objects when iframe is removed from the document. Original Chromium bug report: http://code.google.com/p/chromium/issues/detail?id=85566
Attachments
Patch (18.21 KB, patch)
2011-06-20 09:50 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2011-06-20 09:50:45 PDT
Created attachment 97814 [details] Patch
Pavel Feldman
Comment 2 2011-06-21 02:24:58 PDT
Comment on attachment 97814 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97814&action=review > Source/WebCore/page/DOMWindow.cpp:712 > + InspectorInstrumentation::pageDestroyed(m_frame, this); ::frameWindowDiscarded ?
Yury Semikhatsky
Comment 3 2011-06-21 02:58:49 PDT
Committed r89345: <http://trac.webkit.org/changeset/89345>
Note You need to log in before you can comment on or make changes to this bug.