Bug 62988 - [Skia] remove repeated calls to setColor, which ignored global-alpha (previous setupPaintFor... already set the color+alpha)
Summary: [Skia] remove repeated calls to setColor, which ignored global-alpha (previou...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Reed
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-20 07:41 PDT by Mike Reed
Modified: 2011-06-20 10:24 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2011-06-20 07:43 PDT, Mike Reed 		no flags Details | Formatted Diff | Diff
Patch (3.41 KB, patch)
2011-06-20 09:39 PDT, Mike Reed 		senorblanco: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reed 2011-06-20 07:41:59 PDT 
[Skia] remove repeated calls to setColor, which ignored global-alpha (previous setupPaintFor... already set the color+alpha)
Comment 1 Mike Reed 2011-06-20 07:43:49 PDT 
Created attachment 97799 [details]
Patch
Comment 2 Stephen White 2011-06-20 08:28:59 PDT 
Comment on attachment 97799 [details]
Patch

Looks good.  r=me

Does this affect any tests?  Or only the one previously suppressed?
Comment 3 Mike Reed 2011-06-20 08:34:10 PDT 
this is not related to the previous suppression. It came out of some comments from Eric S. related to redundant code in this file. I have another bug to try to fix more of those separately.  https://bugs.webkit.org/show_bug.cgi?id=62989
Comment 4 WebKit Review Bot 2011-06-20 09:37:58 PDT 
Comment on attachment 97799 [details]
Patch

Clearing flags on attachment: 97799

Committed r89250: <http://trac.webkit.org/changeset/89250>
Comment 5 WebKit Review Bot 2011-06-20 09:38:02 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Mike Reed 2011-06-20 09:39:14 PDT 
Created attachment 97812 [details]
Patch
Comment 7 Stephen White 2011-06-20 10:24:49 PDT 
Comment on attachment 97812 [details]
Patch

Thanks, I'll take what you have here and try to turn it into a script-test (so it doesn't require pixel results).