Bug 62983 – [Qt] LayoutTests/dom/xhtml/level3/core/canonicalform08.xhtml failed

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: New Bugs

[qi]

dom/xhtml/level3/core/canonicalform08.xhtml
dom/xhtml/level3/core/canonicalform09.xhtml
dom/xhtml/level3/core/documentgetinputencoding03.xhtml
dom/xhtml/level3/core/entitygetinputencoding02.xhtml
dom/xhtml/level3/core/entitygetxmlversion02.xhtml
dom/xhtml/level3/core/nodegetbaseuri05.xhtml
dom/xhtml/level3/core/nodegetbaseuri07.xhtml
dom/xhtml/level3/core/nodegetbaseuri09.xhtml
dom/xhtml/level3/core/nodegetbaseuri10.xhtml
dom/xhtml/level3/core/nodegetbaseuri11.xhtml
dom/xhtml/level3/core/nodegetbaseuri15.xhtml
dom/xhtml/level3/core/nodegetbaseuri17.xhtml
dom/xhtml/level3/core/nodegetbaseuri18.xhtml
dom/xhtml/level3/core/nodelookupnamespaceuri01.xhtml
dom/xhtml/level3/core/nodelookupprefix19.xhtml

need rebaseline.

[qi]

Created attachment 97794 [details]
patch

Rebaseline.

[Alexis Menard (darktears)]

Comment on attachment 97794 [details]
patch

LGTM

[Kenneth Rohde Christiansen]

Comment on attachment 97794 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97794&action=review

> LayoutTests/platform/qt/dom/xhtml/level3/core/canonicalform08-expected.txt:2
> -Test	http://www.w3.org/2001/DOM-Test-Suite/level3/core/canonicalform08
> -Status	error
> -Message	TypeError: Undefined value
> +layer at (0,0) size 800x600
> +  RenderView at (0,0) size 800x600

Does the expected result for other ports look like this? I am not sure this is supposed to be a render dump

[qi]

(In reply to comment #3)
> (From update of attachment 97794 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97794&action=review
> 
> > LayoutTests/platform/qt/dom/xhtml/level3/core/canonicalform08-expected.txt:2
> > -Test	http://www.w3.org/2001/DOM-Test-Suite/level3/core/canonicalform08
> > -Status	error
> > -Message	TypeError: Undefined value
> > +layer at (0,0) size 800x600
> > +  RenderView at (0,0) size 800x600
> 
> Does the expected result for other ports look like this? I am not sure this is supposed to be a render dump



Yes, mac and gtk also has itself expected file and they like that I have.

[Chang Shu]

I am not sure if we need a rebaseline again after so many days. Qi, can you run the tests again?

[qi]

I tested on r93047, all the test cases passed now. Close it.

[Laszlo Gombos]

Comment on attachment 97794 [details]
patch

Removing r? to take it out from the review queue. Qi, if I misunderstood the situation and you wanted to keep this up for review please set back the review flag. Thanks !