Bug 62978 - [EFL] ChromeClientEfl doesn't need to check whether m_view is null.
Summary: [EFL] ChromeClientEfl doesn't need to check whether m_view is null.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-20 05:03 PDT by Ryuan Choi
Modified: 2011-06-20 18:33 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.51 KB, patch)
2011-06-20 17:33 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (2.52 KB, patch)
2011-06-20 18:03 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2011-06-20 05:03:47 PDT 
ChromeClientEfl always are created with view and it will not be removed until destroyed.
So, we don't need to check whether m_view is null.
Comment 1 Ryuan Choi 2011-06-20 17:33:08 PDT 
Created attachment 97895 [details]
Patch
Comment 2 Antonio Gomes 2011-06-20 17:45:27 PDT 
Comment on attachment 97895 [details]
Patch

Should not you have ASSERTs instead then?
Comment 3 Ryuan Choi 2011-06-20 18:03:27 PDT 
Created attachment 97898 [details]
Patch
Comment 4 Ryuan Choi 2011-06-20 18:07:49 PDT 
(In reply to comment #2)
> (From update of attachment 97895 [details])
> Should not you have ASSERTs instead then?

Thanks for your comment.

m_view is only changed When called constructor of ChromeClientEfl.
Does we need to add ASSERT before calling m_view every time?

Almost other methods of ChromeClientEfl use m_view without checking m_view.
Comment 5 WebKit Review Bot 2011-06-20 18:32:26 PDT 
The commit-queue encountered the following flaky tests while processing attachment 97898 [details]:

http/tests/local/formdata/send-form-data.html bug 63034 (author: jianli@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Review Bot 2011-06-20 18:33:45 PDT 
Comment on attachment 97898 [details]
Patch

Clearing flags on attachment: 97898

Committed r89327: <http://trac.webkit.org/changeset/89327>
Comment 7 WebKit Review Bot 2011-06-20 18:33:50 PDT 
All reviewed patches have been landed.  Closing bug.