WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
62976
[EFL] Move enum _Ewk_Imh to ewk_view.cpp and remove Ewk_Imh.
https://bugs.webkit.org/show_bug.cgi?id=62976
Summary
[EFL] Move enum _Ewk_Imh to ewk_view.cpp and remove Ewk_Imh.
Grzegorz Czajkowski
Reported
2011-06-20 03:21:01 PDT
These definitions are not used by any API. Enum's values are needed internally in ewk_view.cpp.
Attachments
proposed patch
(1.91 KB, patch)
2011-06-20 03:23 PDT
,
Grzegorz Czajkowski
lucas.de.marchi
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1
2011-06-20 03:23:06 PDT
Created
attachment 97774
[details]
proposed patch
Ryuan Choi
Comment 2
2011-06-20 04:59:04 PDT
ewk_view_imh_get return imh and our browser use it. If it was private, how can we use this return value? IMO, it should not be private.
Raphael Kubo da Costa (:rakuco)
Comment 3
2011-06-20 06:07:24 PDT
Indeed, ewk_view_imh_get does return a value from that enum (perhaps one could even change its type from unsigned int to Ewk_Imh, but that's unrelated to this bug).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug