Bug 6297 - XMLSerializer should use createMarkup
Summary: XMLSerializer should use createMarkup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-30 00:14 PST by Anders Carlsson
Modified: 2019-02-06 09:03 PST (History)
1 user (show)

See Also:


Attachments
Fix some bugs in createMarkup, and make xmlserializer use it (9.36 KB, patch)
2005-12-30 01:52 PST, Anders Carlsson
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2005-12-30 00:14:55 PST
Since we're trying to get rid of NodeImpl::toString, we should use createMarkup in XMLSerializer
Comment 1 Anders Carlsson 2005-12-30 01:52:47 PST
Created attachment 5375 [details]
Fix some bugs in createMarkup, and make xmlserializer use it
Comment 2 Eric Seidel (no email) 2005-12-30 02:05:29 PST
Comment on attachment 5375 [details]
Fix some bugs in createMarkup, and make xmlserializer use it

We talked about this on irc.  You were going to rename escapeHTML to something
like escapeTextForMarkup when landing.

Also, I'm not 100% convinced that we really have enough XMLSerializer tests to
know that this change won't break anything.

Finally, this might have changed one more test case xsltprocessor.html which
should be testing for a document fragment containing only a text node (6180 I
think?).

Assuming you feel the test cases are sufficent, r=me.  Thanks for another great
patch!
Comment 3 Lucas Forschler 2019-02-06 09:03:15 PST
Mass moving XML DOM bugs to the "DOM" Component.