Bug 62964 – Support cast from CSSPrimitiveValue to short and use for CSSPropertyWidows and CSSPropertyOrphans.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Luke Macpherson]

Support cast from CSSPrimitiveValue to short and use for CSSPropertyWidows and CSSPropertyOrphans.

[Luke Macpherson]

Created attachment 97746 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 97746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97746&action=review

These seem kinda scary.  But maybe they're useful?

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

This will cause the cq to fail.  Normally you replace this with a list of tests or why testing is impossible/impractical/unnecessary.

[Luke Macpherson]

(In reply to comment #2)
> (From update of attachment 97746 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97746&action=review
> 
> These seem kinda scary.  But maybe they're useful?
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests. (OOPS!)
> 
> This will cause the cq to fail.  Normally you replace this with a list of tests or why testing is impossible/impractical/unnecessary.

Ack. Yeah just overlooked that.

[Luke Macpherson]

Created attachment 97753 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 97753 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97753&action=review

> Source/WebCore/css/CSSPrimitiveValueMappings.h:57
> +template<> inline CSSPrimitiveValue::operator short() const

I worry that we're getting a bit too fancy here. Will I be able to understand what this means 2 years from now?

[Luke Macpherson]

Since CSSPrimitiveValue is essentially a union of all possible CSS types, including the number type, being able to cast CSSPrimitiveValue to numeric types seems reasonable.

Could you expand on why you think this will be hard to understand (or harder than the numerous other casts that CSSPrimitiveValue supports)?

[Dimitri Glazkov (Google)]

Comment on attachment 97753 [details]
Patch

I think it's because I have an unnatural antipathy toward templates and operators.

[WebKit Review Bot]

Comment on attachment 97753 [details]
Patch

Clearing flags on attachment: 97753

Committed r89448: <http://trac.webkit.org/changeset/89448>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.