Bug 62941 - Git.push_local_commits_to_server() should use passed username and password when we don't have cached credentials
Summary: Git.push_local_commits_to_server() should use passed username and password wh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-18 15:49 PDT by Daniel Bates
Modified: 2011-06-19 06:36 PDT (History)
4 users (show)

See Also:


Attachments
Patch and unit tests (3.36 KB, patch)
2011-06-18 17:28 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2011-06-18 15:49:08 PDT
Following up on Dominic Cooney's comment <https://bugs.webkit.org/show_bug.cgi?id=31500#c39>, Git.push_local_commits_to_server should only raise an AuthenticationError exception when "(not username or not password) and not self.has_authorization_for_realm(SVN.svn_server_realm)". Otherwise, we'll eventually prompt for a username and password but never actually use it.
Comment 1 Daniel Bates 2011-06-18 17:27:15 PDT
When writing unit tests for this I ran into a issue with SCM.find_checkout_root(). See <https://bugs.webkit.org/show_bug.cgi?id=62945#c1> for more details.
Comment 2 Daniel Bates 2011-06-18 17:28:42 PDT
Created attachment 97711 [details]
Patch and unit tests

We'll need to fix bug #62945 in order for the unit tests to run.
Comment 3 Eric Seidel (no email) 2011-06-18 18:06:24 PDT
Comment on attachment 97711 [details]
Patch and unit tests

LGTM.
Comment 4 WebKit Review Bot 2011-06-18 18:55:37 PDT
Comment on attachment 97711 [details]
Patch and unit tests

Clearing flags on attachment: 97711

Committed r89209: <http://trac.webkit.org/changeset/89209>
Comment 5 WebKit Review Bot 2011-06-18 18:55:42 PDT
All reviewed patches have been landed.  Closing bug.