Quite few editing functions take boolean userTriggered argument. We should replace it by an enum.
Created attachment 97844 [details]
Does this need to be FrameSelection::UserTrigggered? or can we have it be global?
Comment on attachment 97844 [details]
Does the enum really need to be a member of FrameSelection? Can’t it be a namespace-level enum?
Heh, Eric and I said the same thing, but I didn’t read his comment until after I posted mine.
Thank for the review. I'll move EUserTriggered out of FrameSelection.
Committed r89293: <http://trac.webkit.org/changeset/89293>
EFL WinCE build fixes: http://trac.webkit.org/changeset/89298
Bit flag collision fix: http://trac.webkit.org/changeset/89299