Bug 62933 - Various editing functions take boolean userTriggered but should be replaced by an enum
Summary: Various editing functions take boolean userTriggered but should be replaced b...
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Depends on:
Reported: 2011-06-18 11:16 PDT by Ryosuke Niwa
Modified: 2011-06-20 15:38 PDT (History)
6 users (show)

See Also:

cleanup (40.28 KB, patch)
2011-06-20 13:10 PDT, Ryosuke Niwa
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-06-18 11:16:41 PDT
Quite few editing functions take boolean userTriggered argument.  We should replace it by an enum.
Comment 1 Ryosuke Niwa 2011-06-20 13:10:58 PDT
Created attachment 97844 [details]
Comment 2 Eric Seidel (no email) 2011-06-20 13:13:05 PDT
Does this need to be FrameSelection::UserTrigggered? or can we have it be global?
Comment 3 Darin Adler 2011-06-20 13:15:49 PDT
Comment on attachment 97844 [details]

Does the enum really need to be a member of FrameSelection? Can’t it be a namespace-level enum?
Comment 4 Darin Adler 2011-06-20 13:16:42 PDT
Heh, Eric and I said the same thing, but I didn’t read his comment until after I posted mine.
Comment 5 Ryosuke Niwa 2011-06-20 13:18:50 PDT
Thank for the review.  I'll move EUserTriggered out of FrameSelection.
Comment 6 Ryosuke Niwa 2011-06-20 15:03:33 PDT
Committed r89293: <http://trac.webkit.org/changeset/89293>
Comment 7 Ryosuke Niwa 2011-06-20 15:38:13 PDT
EFL WinCE build fixes: http://trac.webkit.org/changeset/89298
Bit flag collision fix: http://trac.webkit.org/changeset/89299