Bug 62932 - FrameSelection::modify should take verticalDisplacement instead of verticalDistance
Summary: FrameSelection::modify should take verticalDisplacement instead of verticalDi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-18 11:13 PDT by Ryosuke Niwa
Modified: 2011-06-20 11:33 PDT (History)
8 users (show)

See Also:

Attachments
renamed the argument (3.20 KB, patch)
2011-06-20 09:58 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
added VerticalDirection enum (8.92 KB, patch)
2011-06-20 10:31 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-06-18 11:13:23 PDT 
A distance is the magnitude of a displacement.  We shouldn't be using these terms interchangeably.
Comment 1 Ryosuke Niwa 2011-06-20 09:58:32 PDT 
Created attachment 97816 [details]
renamed the argument
Comment 2 Ryosuke Niwa 2011-06-20 10:03:30 PDT 
Comment on attachment 97816 [details]
renamed the argument

On my second thought, it's probably cleaner to add VerticalDirection enum because callers compute distance and then pass distance or -distance depending.
Comment 3 Ryosuke Niwa 2011-06-20 10:31:49 PDT 
Created attachment 97822 [details]
added VerticalDirection enum
Comment 4 WebKit Review Bot 2011-06-20 11:29:01 PDT 
Comment on attachment 97822 [details]
added VerticalDirection enum

Clearing flags on attachment: 97822

Committed r89263: <http://trac.webkit.org/changeset/89263>
Comment 5 WebKit Review Bot 2011-06-20 11:29:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryosuke Niwa 2011-06-20 11:33:51 PDT 
Thanks for the review, Ojan.  More bool shaving patches are coming!