Bug 62920 – JSONP is unnecessarily slow

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Oliver Hunt]

JSONP is unnecessarily slow

[Oliver Hunt]

Created attachment 97677 [details]
Patch

[Gavin Barraclough]

Comment on attachment 97677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97677&action=review

R+, with changes above.

> Source/JavaScriptCore/interpreter/Interpreter.cpp:766
> +            JSValue baseObject(globalObject);

Please either (1) make this throw the correct errors, or (2) file a bug, add a comment with the bug number here.

> Source/JavaScriptCore/runtime/LiteralParser.cpp:227
> +            return TokAssign;

TokSemi!

> Source/JavaScriptCore/runtime/LiteralParser.cpp:230
> +            while (m_ptr < m_end && (isASCIIAlphanumeric(*m_ptr) || *m_ptr == '_' || *m_ptr == '$'))

I think this while loop is double-checking the identifier start? - not a bug per se, but I think you could add an increment to m_ptr prior to the while & skip a redundant check.

[Oliver Hunt]

Committed r89184: <http://trac.webkit.org/changeset/89184>

[Csaba Osztrogonác]

Reopen, because it was rolled out by http://trac.webkit.org/changeset/89192
SL fails: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r89184%20%2830505%29/results.html

[Oliver Hunt]

Committed r89219: <http://trac.webkit.org/changeset/89219>

[Ryosuke Niwa]

fast/workers/worker-script-error.html is failing on all bots:
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r89219%20(30527)/fast/workers/worker-script-error-pretty-diff.html

-PASS: onerror invoked for a script that has script error 'ReferenceError: Can't find variable: foo' at line 1.
-PASS: event listener invoked for a script that has script error 'ReferenceError: Can't find variable: foo' at line 1.
+PASS: onerror invoked for a script that has script error 'ReferenceError: Can't find variable: foo' at line 0.
+PASS: event listener invoked for a script that has script error 'ReferenceError: Can't find variable: foo' at line 0.

This is change intentional?

[Oliver Hunt]

(In reply to comment #6)
> fast/workers/worker-script-error.html is failing on all bots:
> http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r89219%20(30527)/fast/workers/worker-script-error-pretty-diff.html
> 
> -PASS: onerror invoked for a script that has script error 'ReferenceError: Can't find variable: foo' at line 1.
> -PASS: event listener invoked for a script that has script error 'ReferenceError: Can't find variable: foo' at line 1.
> +PASS: onerror invoked for a script that has script error 'ReferenceError: Can't find variable: foo' at line 0.
> +PASS: event listener invoked for a script that has script error 'ReferenceError: Can't find variable: foo' at line 0.
> 
> This is change intentional?

No. fixed.