Bug 62913 - Use ICU search collator when available
Summary: Use ICU search collator when available
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Keywords: InRadar
Depends on:
Reported: 2011-06-17 15:44 PDT by Alexey Proskuryakov
Modified: 2011-07-20 13:52 PDT (History)
4 users (show)

See Also:

proposed patch (1.76 KB, patch)
2011-06-17 15:49 PDT, Alexey Proskuryakov
mitz: review+
Details | Formatted Diff | Diff
patch for landing (1.76 KB, patch)
2011-06-17 15:58 PDT, Alexey Proskuryakov
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
actually truly no tabs (1.78 KB, patch)
2011-06-17 17:14 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-06-17 15:44:19 PDT
New versions of ICU provide a collator that's specifically made for searching, and respects searching rules. We should be using it.

Comment 1 Alexey Proskuryakov 2011-06-17 15:49:10 PDT
Created attachment 97662 [details]
proposed patch

I do not know everything that's going to change; hoping for a silver bullet solution for all search problems.
Comment 2 WebKit Review Bot 2011-06-17 15:51:58 PDT
Attachment 97662 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2011-06-17 15:58:06 PDT
Created attachment 97664 [details]
patch for landing
Comment 4 mitz 2011-06-17 16:02:08 PDT
Do I need to do anything with the newer patch?
Comment 5 Alexey Proskuryakov 2011-06-17 16:18:51 PDT
Sorry, I meant to cq+ it.
Comment 6 WebKit Review Bot 2011-06-17 16:58:35 PDT
Comment on attachment 97664 [details]
patch for landing

Rejecting attachment 97664 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2

Last 500 characters of output:
U    /mnt/git/webkit-commit-queue/Source/WebKit/chromium/third_party/skia/include/core/SkBlitter.h
U    /mnt/git/webkit-commit-queue/Source/WebKit/chromium/third_party/skia/include/core/SkPoint.h
U    /mnt/git/webkit-commit-queue/Source/WebKit/chromium/third_party/skia/include/views/SkOSWindow_Android.h
Updated to revision 1613.

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/8880739
Comment 7 Alexey Proskuryakov 2011-06-17 17:14:11 PDT
Created attachment 97668 [details]
actually truly no tabs
Comment 8 WebKit Review Bot 2011-06-17 17:43:27 PDT
Comment on attachment 97668 [details]
actually truly no tabs

Clearing flags on attachment: 97668

Committed r89181: <http://trac.webkit.org/changeset/89181>
Comment 9 WebKit Review Bot 2011-06-17 17:43:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Jungshik Shin 2011-07-20 12:15:49 PDT
Argh. This broke Korean search completely with ICU 4.6 (with CLDR 1.9.x) that has a search collator for Korean. (http://crbug.com/88434 ).
Comment 11 Alexey Proskuryakov 2011-07-20 13:14:55 PDT
Could you please file a new bug report with detailed steps to reproduce? I tried, but couldn't reproduce on Lion (which has ICU 4.6).
Comment 12 Jungshik Shin 2011-07-20 13:52:19 PDT
I've just filed bug 64892. Could you try to reproduce with Safari on Lion?