New versions of ICU provide a collator that's specifically made for searching, and respects searching rules. We should be using it. <rdar://problem/8830218> <rdar://problem/8468873>
Created attachment 97662 [details] proposed patch I do not know everything that's going to change; hoping for a silver bullet solution for all search problems.
Attachment 97662 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 97664 [details] patch for landing
Do I need to do anything with the newer patch?
Sorry, I meant to cq+ it.
Comment on attachment 97664 [details] patch for landing Rejecting attachment 97664 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: clude/core/SkScalar.h U /mnt/git/webkit-commit-queue/Source/WebKit/chromium/third_party/skia/include/core/SkBlitter.h U /mnt/git/webkit-commit-queue/Source/WebKit/chromium/third_party/skia/include/core/SkPoint.h U /mnt/git/webkit-commit-queue/Source/WebKit/chromium/third_party/skia/include/views/SkOSWindow_Android.h Updated to revision 1613. ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/8880739
Created attachment 97668 [details] actually truly no tabs
Comment on attachment 97668 [details] actually truly no tabs Clearing flags on attachment: 97668 Committed r89181: <http://trac.webkit.org/changeset/89181>
All reviewed patches have been landed. Closing bug.
Argh. This broke Korean search completely with ICU 4.6 (with CLDR 1.9.x) that has a search collator for Korean. (http://crbug.com/88434 ).
Could you please file a new bug report with detailed steps to reproduce? I tried, but couldn't reproduce on Lion (which has ICU 4.6).
I've just filed bug 64892. Could you try to reproduce with Safari on Lion?