Bug 62907 - [chromium] force rebaseline-chromium-webkit-tests to use the chromium port
Summary: [chromium] force rebaseline-chromium-webkit-tests to use the chromium port
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
: 61833 (view as bug list)
Depends on:
Reported: 2011-06-17 13:54 PDT by Tony Chang
Modified: 2011-06-17 14:48 PDT (History)
2 users (show)

See Also:

Patch (2.20 KB, patch)
2011-06-17 13:56 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-06-17 13:54:35 PDT
[chromium] force rebaseline-chromium-webkit-tests to use the chromium port
Comment 1 Tony Chang 2011-06-17 13:56:27 PDT
Created attachment 97649 [details]
Comment 2 Dirk Pranke 2011-06-17 13:58:48 PDT
Comment on attachment 97649 [details]

This is fine. See the email I just sent you, though, I don't think this explains rniwa's problem (it might fix it, but there's probably another bug in here somewhere). 

Ideally we'd find whatever ImageDiff was built, but that can certainly be a separate patch.
Comment 3 Tony Chang 2011-06-17 14:02:28 PDT
See the ChangeLog description.  Even with a tolerance of 0, it doesn't do an exact pixel match.  Here's the code in question:

It calculates a distance and if the distance is small enough, it considers the pixels the same.
Comment 4 Tony Chang 2011-06-17 14:02:59 PDT
*** Bug 61833 has been marked as a duplicate of this bug. ***
Comment 5 Dirk Pranke 2011-06-17 14:06:54 PDT
Wow, that just seems like a bug. It seems like --tolerance=0 should mean "exact match".
Comment 6 WebKit Review Bot 2011-06-17 14:48:25 PDT
Comment on attachment 97649 [details]

Clearing flags on attachment: 97649

Committed r89174: <http://trac.webkit.org/changeset/89174>
Comment 7 WebKit Review Bot 2011-06-17 14:48:31 PDT
All reviewed patches have been landed.  Closing bug.